Database content fixes#61
Open
samuel-skean wants to merge 4 commits into
Open
Conversation
not to nearest time after now. Pros: + Matches expectations + button label better + Lets students review more easily in-class by jumping to the current lecture while in class, not the event that *begins* next + more readable date comparisons + No more unsightly `+new Date(/* ommitted code */)` + In fact, no more raw javascript `Date` Con: - `dayjs` gets shipped client-side
I find this logic kinda questionable, but it makes some sense. Basically it is: If any of the rows (that represent events) found when parsing the list of events on a press of the "Jump to Date Button" have a null "data-date" attribute, pretend that event is happening today. My previous commit changed this logic subtly such that it didn't make any sense - checking if the result of `dayjs` was null, instead of if the attribute was null, in 2 of 3 cases - and forgetting to check at all in the 3rd case (whoops).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small clarification to databases section.