test(adapters): add unit tests for 4 unified adapter modules#972
Merged
test(adapters): add unit tests for 4 unified adapter modules#972
Conversation
Adds dedicated unit tests for 4 unified adapter modules that lacked coverage after the #955 batch: - tests/unit/test_ws_connection_adapter.cpp (17 tests) - tests/unit/test_ws_listener_adapter.cpp (17 tests) - tests/unit/test_quic_connection_adapter.cpp (17 tests) - tests/unit/test_quic_listener_adapter.cpp (17 tests) Tests cover construction, accessor methods, error paths, and state transitions without requiring live network. New targets registered in tests/CMakeLists.txt. Local run: 196/196 adapter tests pass (0.66s). Part of #953.
Adds Unreleased entries to both root CHANGELOG.md and the docs/CHANGELOG.md SSOT noting the 4 new unified adapter unit test files introduced by #967.
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #967
Summary
Why
Part of epic #953 — expand unit test coverage from 40% to 80%. The original issue #967 listed 17 adapter modules as untested, but gap analysis found 13 were already covered by #955. This PR completes the remaining 4.
Where
How / Test plan
Local verification (macOS, bash 5.3, cmake 4.3):
cmake --preset release && cmake --build build
cd build && ctest --output-on-failure -L unit
Result: 196/196 adapter tests pass (0.66s), no GTEST_SKIP markers.
CI-required coverage:
Review Summary
Commits