Skip to content

test(adapters): add unit tests for 4 unified adapter modules#972

Merged
kcenon merged 2 commits intodevelopfrom
feat/issue-967-adapter-unit-tests
Apr 15, 2026
Merged

test(adapters): add unit tests for 4 unified adapter modules#972
kcenon merged 2 commits intodevelopfrom
feat/issue-967-adapter-unit-tests

Conversation

@kcenon
Copy link
Copy Markdown
Owner

@kcenon kcenon commented Apr 15, 2026

Closes #967

Summary

  • Adds unit tests for 4 unified adapter modules: ws_connection, ws_listener, quic_connection, quic_listener (68 new tests)
  • Registers new targets in tests/CMakeLists.txt
  • Updates CHANGELOG.md and docs/CHANGELOG.md

Why

Part of epic #953 — expand unit test coverage from 40% to 80%. The original issue #967 listed 17 adapter modules as untested, but gap analysis found 13 were already covered by #955. This PR completes the remaining 4.

Where

  • tests/unit/test_ws_connection_adapter.cpp (+)
  • tests/unit/test_ws_listener_adapter.cpp (+)
  • tests/unit/test_quic_connection_adapter.cpp (+)
  • tests/unit/test_quic_listener_adapter.cpp (+)
  • tests/CMakeLists.txt (modified — 4 new test targets)
  • CHANGELOG.md, docs/CHANGELOG.md (modified — Added entries)

How / Test plan

Local verification (macOS, bash 5.3, cmake 4.3):
cmake --preset release && cmake --build build
cd build && ctest --output-on-failure -L unit

Result: 196/196 adapter tests pass (0.66s), no GTEST_SKIP markers.

CI-required coverage:

  • Ubuntu GCC/Clang, Windows MSVC, macOS
  • Sanitizer variants (ASAN/TSAN/UBSAN)

Review Summary

  • Gap analysis (Task 6): No critical findings — all 4 missing modules implemented, covers construction/error-paths per acceptance criteria.
  • Code review (Task 7): Approved — no change requests (see team message log).
  • No Minor/Info items outstanding.

Commits

kcenon added 2 commits April 15, 2026 21:33
Adds dedicated unit tests for 4 unified adapter modules that lacked
coverage after the #955 batch:

- tests/unit/test_ws_connection_adapter.cpp (17 tests)
- tests/unit/test_ws_listener_adapter.cpp (17 tests)
- tests/unit/test_quic_connection_adapter.cpp (17 tests)
- tests/unit/test_quic_listener_adapter.cpp (17 tests)

Tests cover construction, accessor methods, error paths, and state
transitions without requiring live network. New targets registered in
tests/CMakeLists.txt.

Local run: 196/196 adapter tests pass (0.66s).

Part of #953.
Adds Unreleased entries to both root CHANGELOG.md and the docs/CHANGELOG.md
SSOT noting the 4 new unified adapter unit test files introduced by #967.
@kcenon kcenon merged commit 3ad4118 into develop Apr 15, 2026
13 checks passed
@kcenon kcenon deleted the feat/issue-967-adapter-unit-tests branch April 15, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant