Conversation
- symfony/console 3.4 -> 7.4, symfony/event-dispatcher 6.4 -> 7.4, symfony/config 6.4 -> 7.4 - Fix execute() signatures: public ?int -> protected int (Symfony 7 requirement) - Replace $defaultName with #[AsCommand] attribute in QueueMassTerminateJobs - Fix PHPStan errors: use getArgument() with assertions instead of getArguments() - Remove unused psr/log direct dependency
There was a problem hiding this comment.
Pull request overview
Upgrades this CLI utilities project to Symfony 7.4 LTS and aligns command implementations with Symfony 7’s Console API expectations (command registration + execute() signatures), while refreshing the dependency lockfile accordingly.
Changes:
- Upgrade Symfony components to
^7.4(notablysymfony/console,symfony/event-dispatcher,symfony/config) and updatecomposer.lockto match. - Update multiple console commands to Symfony 7-compatible
execute()signatures and adjust argument access for stricter typing. - Migrate
QueueMassTerminateJobsfrom deprecated$defaultNameto#[AsCommand].
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
composer.json |
Bumps Symfony requirements to ^7.4 and removes direct psr/log requirement. |
composer.lock |
Large lock refresh to Symfony 7.4-era dependency graph and updated transitive packages. |
src/Keboola/Console/Command/UpdateDataRetention.php |
Updates execute() signature + argument retrieval/assertions for Symfony 7 typing. |
src/Keboola/Console/Command/QueueMassTerminateJobs.php |
Replaces $defaultName with #[AsCommand] attribute. |
src/Keboola/Console/Command/ProjectsRemoveFeature.php |
Updates execute() signature for Symfony 7. |
src/Keboola/Console/Command/ProjectsAddFeature.php |
Updates execute() signature + argument retrieval/assertions. |
src/Keboola/Console/Command/OrganizationsAddFeature.php |
Updates execute() signature + argument retrieval/assertions. |
src/Keboola/Console/Command/AllStacksIterator.php |
Updates execute() signature for Symfony 7. |
src/Keboola/Console/Command/AddFeature.php |
Updates execute() signature + argument retrieval/assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vojtabiberle
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^7.4LTS (console 3.4 -> 7.4, event-dispatcher 6.4 -> 7.4, config 6.4 -> 7.4)execute()signatures in 6 command files (public ?int->protected int) as required by Symfony 7$defaultNameproperty with#[AsCommand]attribute inQueueMassTerminateJobsgetArguments()->getArgument()+ assertions)psr/logdependencysymfony/debug,symfony/polyfill-php80,symfony/polyfill-php81Test plan
php cli.php listloads all 24 commands