feat: implement RFC 6763 Section 4.3 escaping for instance names #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper escaping of dots and backslashes in DNS-SD instance names according to RFC 6763 Section 4.3: - '.' becomes '\.' - '\' becomes '\\' This ensures that literal dots in instance names (e.g., "My.Service") are not interpreted as DNS label separators when constructing the Service Instance Name. Fixes improper handling of instance names containing dots or backslashes.
thibaut-pascal
force-pushed
the
rcf6763_instance_name
branch
from
c515d2e to
13a7bf7
Compare
thibaut-pascal
commented
Jan 20, 2026
Owner
|
The description section seems to be missing backslash in these:
I think it's because of Markdown syntax, and should use ``, not '' for them. |
keepsimple1
reviewed
Jan 25, 2026
Owner
keepsimple1
left a comment
keepsimple1
left a comment
There was a problem hiding this comment.
Thanks for your PR! LGTM, only a couple of minor comments inline.
keepsimple1
reviewed
Jan 25, 2026
Owner
|
Another small thing: could you please explicitly refer to the issue number in this PR description? |
keepsimple1
approved these changes
Feb 6, 2026
Owner
keepsimple1
left a comment
keepsimple1
left a comment
There was a problem hiding this comment.
Overall LGTM, so I will merge this before it's getting too old ;-)
For reference, this is to fix issue #418 .
keepsimple1
added a commit
that referenced
this pull request
Feb 6, 2026
Update comments per unresolved comments in PR #420.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper escaping of dots and backslashes in DNS-SD instance names according to RFC 6763 Section 4.3:
This ensures that literal dots in instance names (e.g., "My.Service") are not interpreted as DNS label separators when constructing the Service Instance Name.
Fixes improper handling of instance names containing dots or backslashes.