Skip to content

fix: invert reuseport feature #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keepsimple1 merged 3 commits into from
Feb 10, 2026
Merged

fix: invert reuseport feature #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c91e8e
fix: invert reuseport feature
keepsimple1 Feb 7, 2026
8e801b0
add a comment
keepsimple1 Feb 8, 2026
72b1720
log the reuseport error and move on
keepsimple1 Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ categories = ["network-programming"]
description = "mDNS Service Discovery library with no async runtime dependency"

[features]
reuseport = []
async = ["flume/async"]
logging = ["log"]
default = ["reuseport", "async", "logging"]
default = ["async", "logging"]

[dependencies]
fastrand = "2.3"
Expand Down
10 changes: 7 additions & 3 deletions src/service_daemon.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,9 +741,13 @@ fn new_socket(addr: SocketAddr, non_block: bool) -> Result<PktInfoUdpSocket> {

fd.set_reuse_address(true)
.map_err(|e| e_fmt!("set ReuseAddr failed: {}", e))?;
#[cfg(all(unix, feature = "reuseport"))] // this is currently restricted to Unix's in socket2
fd.set_reuse_port(true)
.map_err(|e| e_fmt!("set ReusePort failed: {}", e))?;
#[cfg(unix)]
if let Err(e) = fd.set_reuse_port(true) {
debug!(
"SO_REUSEPORT is not supported, continuing without it: {}",
e
);
}

if non_block {
fd.set_nonblocking(true)
Expand Down