Additional table create change#17
Open
blagojabozinovski wants to merge 2 commits into
Open
Conversation
blagojabozinovski
commented
Mar 27, 2025
blagojabozinovski
commented
- Change the way the additional validation table is created
- Change the function that checks if the validation table exists
ThrawnCA
suggested changes
Mar 30, 2025
| finished = Column(DateTime) | ||
| report = Column(JSON) | ||
| error = Column(JSON) | ||
| mapper(Validation, validation_table) |
There was a problem hiding this comment.
This function is going away in SQLAlchemy 2.0.
ThrawnCA
reviewed
Mar 30, 2025
|
|
||
| def tables_exist(): | ||
| return Validation.__table__.exists() | ||
| eng = sa.create_engine(config.get('sqlalchemy.url')) |
There was a problem hiding this comment.
This is a very inelegant approach. The create_tables function is idempotent so this function is not really needed anyway.
|
For reference: https://github.com/qld-gov-au/ckanext-validation/blob/master/ckanext/validation/model.py is compatible with latest CKAN master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.