feat: add Homebrew formula and update workflow for automatic formula …#818
feat: add Homebrew formula and update workflow for automatic formula …#818stearz wants to merge 1 commit intokelos-dev:mainfrom
Conversation
There was a problem hiding this comment.
2 issues found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="hack/update-homebrew-formula.sh">
<violation number="1" location="hack/update-homebrew-formula.sh:15">
P2: The script downloads a release asset named `checksums.txt` but then reads `/tmp/kelos-checksums.txt`. Since the checksums file generated by the release process is `checksums.txt`, the parsing loop will fail when the file isn’t renamed. This will abort the formula update.</violation>
</file>
<file name=".github/workflows/release.yaml">
<violation number="1" location=".github/workflows/release.yaml:99">
P2: Release workflow pushes from a detached HEAD on tag builds; `git push` will fail or not update main, so the Homebrew formula update won’t land.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/release.yaml">
<violation number="1" location=".github/workflows/release.yaml:99">
P1: Tag-triggered workflow may fail to push formula updates because `git push origin main` requires a local `main` ref that is not guaranteed in tag checkout context.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
b347492 to
5e57e3d
Compare
|
I fixed a conflict and squashed the commits. Ready to review |
|
Alright, fixed verify issues and amended the the commit. NOW it is ready for review and merge. Beware that this PR needs to be merged before so the tap repo is as expected: kelos-dev/homebrew-tap#1 Additionally you need to set up a PAT that is allowed to make changes to the tap repo and give it to the kelos repo as a TAP_GITHUB_TOKEN secret: It would be more elegant if we would use goreleaser but that would require more work because it would interfer with your existing build and release notes automation. I therfor decided to not go that way. Hope to be able to install and especially update (that's the bigger value) kelos with homebrew soon. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds Homebrew installation support for Kelos, allowing users to install and manage Kelos via:
This improves the installation experience and makes Kelos discoverable through a widely-used package manager.
This PR includes:
The formula is automatically updated with correct checksums and version on every release, requiring no manual intervention.
Which issue(s) this PR is related to:
Fixes #817
Special notes for your reviewer:
if: github.actor != 'kelos-dev[bot]')update-homebrew-formula.shscript handles downloading checksums from the GitHub release and updating the formulaDoes this PR introduce a user-facing change?
Yes - a new installation method.