Add multi-architecture support for Docker images and workflows#841
Open
stearz wants to merge 1 commit intokelos-dev:mainfrom
Open
Add multi-architecture support for Docker images and workflows#841stearz wants to merge 1 commit intokelos-dev:mainfrom
stearz wants to merge 1 commit intokelos-dev:mainfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Makefile">
<violation number="1" location="Makefile:108">
P2: `image-multiarch` hardcodes prebuilt arches (`amd64 arm64`) while `--platform` uses configurable `IMAGE_PLATFORMS`, which can produce missing per-arch binaries when platforms are overridden.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
github-actions
bot
added
needs-triage
needs-kind
Collaborator
|
This is a duplicate of #787 |
Contributor
Author
|
It would be cool if ypu merge one of them. 😉 |
| with: | ||
| go-version-file: go.mod | ||
|
|
||
| - name: Set up QEMU |
Contributor
There was a problem hiding this comment.
My experience with this in #787 was that QEMU is very, very slow. like 60 minutes per run.
I swapped to running on ARM runners, example: https://github.com/datagravity-ai/kelos/blob/prod/.github/workflows/ci.yaml and it went to 2-3 minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
adds support for arm64
Which issue(s) this PR is related to:
Fixes #840
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?
yes, containers now also run on arm64 machines
Summary by cubic
Add multi-arch Docker builds (linux/amd64, linux/arm64) and update the release workflow to build and push them with Buildx. Images now run natively on ARM (Apple Silicon) and x86. Fixes #840.
New Features
image-multiarch;imagenow builds for the host arch; passTARGETARCHtodocker build.ARG TARGETARCHand copy arch-specific binaries (*-linux-$ARCH).docker/setup-qemu-action@v3anddocker/setup-buildx-action@v3; switched to a single build-and-push step;latesttags are multi-arch on releases.Migration
make image-multiarchto publish multi-arch images (requires Docker Buildx).make imagebuilds for your machine’s arch; override withLOCAL_ARCH=amd64if needed.Written for commit 7300235. Summary will update on new commits.