Attempt at solving issue with both Arc and Brave resolving to the same short name#32
Open
jonasbn wants to merge 5 commits intokerma:masterfrom
Open
Attempt at solving issue with both Arc and Brave resolving to the same short name#32jonasbn wants to merge 5 commits intokerma:masterfrom
jonasbn wants to merge 5 commits intokerma:masterfrom
Conversation
…on, this is a hack
|
@kerma I'd love to see this merged in, any chance you could review the PR and push this in? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When going over some of the issues, I installed both Arc and Brave. Unfortunately they resolve to the same short name:
browser.com.brave.Browser (browser)com.googlecode.iterm2 (iterm2)com.google.Chrome (chrome)org.mozilla.firefoxdeveloperedition (firefoxdeveloperedition)com.apple.Safari (safari)app.zen-browser.zen (zen)company.thebrowser.Browser (browser)When I finally wrapped my head around the resolution of the short name. I thought it was an official name, see: #27, I could list and manipulate both browsers.
The solution is not optimal since it might invite into extending the list, but this PR is more of a suggestion to look into this since you might come up with a better long term solution.
Take care,
jonasbn