Skip to content

Add fallback for blog search when API returns no results for short queries#4276

Closed
iitzIrFan wants to merge 13 commits intokestra-io:mainfrom
iitzIrFan:fix/search-facet-results
Closed

Add fallback for blog search when API returns no results for short queries#4276
iitzIrFan wants to merge 13 commits intokestra-io:mainfrom
iitzIrFan:fix/search-facet-results

Conversation

@iitzIrFan
Copy link
Copy Markdown
Contributor

fixes: #4199


Reference: #4199 (comment)


@github-project-automation github-project-automation Bot moved this to To review in Pull Requests Mar 18, 2026
@MilosPaunovic MilosPaunovic added area/frontend Needs frontend code changes kind/external Pull requests raised by community contributors labels Mar 18, 2026
Copy link
Copy Markdown
Contributor

@Piyush-r-bhaskar Piyush-r-bhaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @iitzIrFan

But I feel you understand the issue vague.

Issue is around searching the some term not working and it's not like blogs search is completely broken. see attached and could you investigate it fully ?

Screen.Recording.2026-03-19.at.2.30.33.PM.mov

@Piyush-r-bhaskar Piyush-r-bhaskar moved this from To review to On hold in Pull Requests Mar 20, 2026
@MilosPaunovic
Copy link
Copy Markdown
Member

Any updates on this one @iitzIrFan?

@iitzIrFan
Copy link
Copy Markdown
Contributor Author

Thanks for the ping on this, @MilosPaunovic. The issue has been partially narrowed down. Currently, blog results do not appear when a user types three characters, but they start appearing from the fourth character onward. I will update this PR to ensure results are shown from the first character, consistent with the behavior in other tabs. I will share an update by EOD.
https://github.com/user-attachments/assets/d51f0d14-74cf-4e3c-8cae-0cb91670cf36

@iitzIrFan
Copy link
Copy Markdown
Contributor Author

iitzIrFan commented Mar 24, 2026

The api seems to be more optimized on blogs side, so implemented a blog fallback and it's works from the very first key stroke as per the below preview,
https://github.com/user-attachments/assets/526cd188-fb08-4c68-b049-3bef4b922ab0

@iitzIrFan iitzIrFan changed the title fix(search): handle empty search queries gracefully Add fallback for blog search when API returns no results for short queries Mar 24, 2026
@MilosPaunovic MilosPaunovic moved this from On hold to To review in Pull Requests Mar 24, 2026
@Piyush-r-bhaskar
Copy link
Copy Markdown
Contributor

Hey @iitzIrFan

This kinda fallback doesn't smell good. I feel there is something in how we constructs the query in api https://api.kestra.io/v1/search

I will look and also also check with BE first to decide how to proceed on this PR

@iitzIrFan
Copy link
Copy Markdown
Contributor Author

iitzIrFan commented Apr 1, 2026

Sure @Piyush-r-bhaskar

@github-project-automation github-project-automation Bot moved this from To review to Done in Pull Requests Apr 1, 2026
@Piyush-r-bhaskar
Copy link
Copy Markdown
Contributor

Handled on API level

@iitzIrFan
Copy link
Copy Markdown
Contributor Author

Thanks for update @Piyush-r-bhaskar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend Needs frontend code changes kind/do-not-merge Don't merge kind/external Pull requests raised by community contributors

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Search on blog are not working

3 participants