Skip to content

Add person_number to Officer response model #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevbite merged 3 commits into from
Apr 14, 2026
Merged

Add person_number to Officer response model #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ba2275
Initial plan
Copilot Apr 13, 2026
e22cbd3
Add person_number field to Officer response model
Copilot Apr 13, 2026
4fe3998
Remove accidentally committed nuget.exe and add .nuget/ to .gitignore
Copilot Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ publish/
*.nupkg
!**/packages/build/
packages/
#.nuget/NuGet.exe
.nuget/

# Windows Azure Build Output
csx
Expand Down
3 changes: 3 additions & 0 deletions src/CompaniesHouse/Response/Officers/Officer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,8 @@ public class Officer

[JsonProperty(PropertyName = "links")]
public OfficerLinks Links { get; set; }

[JsonProperty(PropertyName = "person_number")]
public string PersonNumber { get; set; }
}
}
2 changes: 2 additions & 0 deletions tests/CompaniesHouse.Tests/ResourceBuilders/Officer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,7 @@ public class Officer
public OfficerIdentification Identification { get; set; }

public OfficerLinks Links { get; set; }

public string PersonNumber { get; set; }
}
}
3 changes: 2 additions & 1 deletion tests/CompaniesHouse.Tests/ResourceBuilders/OfficersResourceBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ public static string CreateSingle(Officer officer)
""legal_form"": ""{officer.Identification.LegalForm}"",
""place_registered"": ""{officer.Identification.PlaceRegistered}"",
""registration_number"": ""{officer.Identification.RegistrationNumber}""
}}
}},
""person_number"" : ""{officer.PersonNumber}""
}}";
}

Expand Down
Loading