Conversation
Pull Request Test Coverage Report for Build 14546562354Details
💛 - Coveralls |
kfly8
added a commit
that referenced
this pull request
Apr 19, 2025
Changelog diff is: diff --git a/Changes b/Changes index 72aa9ca..693bf60 100644 --- a/Changes +++ b/Changes @@ -1,6 +1,8 @@ Revision history for Perl extension Result-Simple {{$NEXT}} + +0.05 2025-04-19T23:07:50Z - Improve stactrace #4 - [ENHANCEMENTS] - Added `combine` and `combine_with_all_errors`` helpers #5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
Result::Simplemodule to improve code readability and maintainability, enhances thepipelinefunction by assigning a subroutine name for better debugging, and updates the test suite to improve stack trace validation and coverage. Below are the most important changes grouped by theme:Code Refactoring and Enhancements:
chainandpipelinefunctions for clarity ($fto$function,@fto@functions) and updated related logic to improve readability. (lib/Result/Simple.pm, lib/Result/Simple.pmL147-R174)__PIPELINED_FUNCTION__) to thepipelinefunction usingSub::Util::set_subnamefor better debugging and stack trace clarity. (lib/Result/Simple.pm, lib/Result/Simple.pmL179-R194)Test Suite Improvements:
t/Result-Simple.t, [1] [2] [3]notestatements in tests to provide additional debugging information about stack trace lines. (t/Result-Simple.t, [1] [2] [3]diesfor exception validation and improved consistency in stack trace checks for cases whereCHECK_ENABLEDis falsy. (t/check-disabled.t, [1] [2]Minor Updates:
noteto theTest2::V0imports in test files to enable additional debugging output. (t/Result-Simple.t, [1];t/check-disabled.t, [2]