You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@iamnabink
The PR mentions matching Khalti branding, but no actual brand color is used. The hardcoded Color(0xFFE8F0F7) also caused visibility issues. It’s better to rely on the app’s theme or use an official brand color of Khalti(Color(0xFFDC0019)) with foregroundColor: Colors.white.
So my proposed change is:
//uses your app brand Color
title: const Text(s_payWithKhalti),
actions: [
IconButton(
onPressed: _reload,
icon: const Icon(Icons.refresh),
)
],
elevation: 4,
),
Use the app’s brand color via AppBarTheme defined in MaterialApp instead of hardcoding colors.
appBarTheme: const AppBarTheme(
centerTitle: true,
foregroundColor: Colors.white,
backgroundColor: primaryColor,
elevation: 0,
),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently payment page has white non-visible appbar which needs to be changed to something visible so added default khalti brand color.