ci: always run required checks on PRs; fix stale Test check name#154
Merged
Conversation
Two coupled gaps let PRs sit BLOCKED and forced --admin merges:
1. `paths-ignore: ['**.md', ...]` skipped CI entirely for a doc/CHANGELOG-only
PR, so the required checks (Lint, Test, Bench gate) never reported and the PR
stayed BLOCKED ("Expected — waiting for status"). The v0.41.0 release PR hit
exactly this. Drop paths-ignore from the `pull_request` trigger so PRs always
run CI and report; keep it on `push` so direct main pushes (memory/docs/
CHANGELOG) stay cheap. (pricing.yaml / testdata are not ignored, so catalog
edits already got CI — the memory note that they skipped CI was inaccurate.)
2. Branch protection requires the check "Test (ubuntu-latest)", but the test job
had dropped its OS matrix and reported bare "Test", so the required context
was never satisfied — every merge needed --admin. Restore a single-OS matrix
so the job reports "Test (ubuntu-latest)" again.
This PR touches .github/, so it runs CI and should be the first to satisfy the
required "Test (ubuntu-latest)" context — mergeable without --admin.
Claude-Session: https://claude.ai/code/session_01QKTcmXFTKoTQr7mB3HCuHZ
felixgeelhaar
added a commit
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two coupled gaps let PRs sit
BLOCKEDand forced--adminmerges all through the pricing arc.1. Doc-only PRs skipped CI → required checks never reported
ci.ymlusedpaths-ignore: ['**.md', 'docs/**', 'LICENSE']on both triggers, so a PR touching only those paths (a CHANGELOG-only release PR) skipped CI entirely — the requiredLint/Test/Bench gatechecks never reported and the PR stayedBLOCKED("Expected — waiting for status"). The v0.41.0 release PR (#153) hit exactly this and merged via--admin.Fix: drop
paths-ignorefrom thepull_requesttrigger (PRs always run CI and report), keep it onpushso direct main pushes (memory/docs/CHANGELOG) stay cheap.Note:
pricing.yaml/testdataare.yaml/.json, never matched**.md, so catalog edits already got full CI — the earlier memory note that they skipped CI was inaccurate. The real gap was doc-only PRs.2. Stale required check name → every merge needed
--adminBranch protection requires the context
Test (ubuntu-latest), but thetestjob had lost its OS matrix and reported bareTest, so the required context was never satisfied on any PR. Restore a single-OS matrix (os: [ubuntu-latest]) so the job reportsTest (ubuntu-latest)again (extends cleanly if more OSes are added).Self-validation
This PR touches
.github/, so it runs CI and should be the first PR to actually satisfy theTest (ubuntu-latest)required context — i.e. it should go green and be mergeable without--admin. That's the proof the fix works.https://claude.ai/code/session_01QKTcmXFTKoTQr7mB3HCuHZ