This repository was archived by the owner on Jul 19, 2024. It is now read-only.
feat(template-controller): aggregated user-facing cluster roles for all custom resources#33
Open
erikgb wants to merge 1 commit intokluctl:mainfrom
Open
feat(template-controller): aggregated user-facing cluster roles for all custom resources#33erikgb wants to merge 1 commit intokluctl:mainfrom
erikgb wants to merge 1 commit intokluctl:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While trying to install template-controller, I noticed that user-facing RBAC to some custom resources was missing. In addition, the cluster roles are lacking the labels making them aggregate rules to the default Kubernetes user-facing roles.
NOTE: This change might be considered breaking by some users - since some cluster roles are removed in this PR.
Type of change
Please delete options that are not relevant.