Skip to content

fix: replace plugin-image-zoom with docusaurus-plugin-image-zoom#279

Open
MeloveGupta wants to merge 1 commit into
kmesh-net:mainfrom
MeloveGupta:fix/plugin-image-zoom
Open

fix: replace plugin-image-zoom with docusaurus-plugin-image-zoom#279
MeloveGupta wants to merge 1 commit into
kmesh-net:mainfrom
MeloveGupta:fix/plugin-image-zoom

Conversation

@MeloveGupta
Copy link
Copy Markdown

Replaced plugin-image-zoom (which was pointing to a private GitHub repo via flexanalytics/plugin-image-zoom) with the public npm package docusaurus-plugin-image-zoom.

The Netlify build was failing because it couldn't pull a dependency from a private GitHub repo over SSH. Anyone trying to build this project fresh including CI would hit the same wall.

  • Removed the old dependency
  • Installed docusaurus-plugin-image-zoom from npm
  • Updated the plugin name in docusaurus.config.js to match
  • Regenerated yarn.lock

Fixes #248

Signed-off-by: Melove <melovegupta0406@gmail.com>
Copilot AI review requested due to automatic review settings May 1, 2026 13:28
@kmesh-bot kmesh-bot requested review from jayesh9747 and nlgwcy May 1, 2026 13:28
@netlify
Copy link
Copy Markdown

netlify Bot commented May 1, 2026

Deploy Preview for kmesh-net ready!

Name Link
🔨 Latest commit cfd0fea
🔍 Latest deploy log https://app.netlify.com/projects/kmesh-net/deploys/69f4aa687543150008ecaf80
😎 Deploy Preview https://deploy-preview-279--kmesh-net.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kmesh-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lizhencheng9527 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the plugin-image-zoom dependency with the official docusaurus-plugin-image-zoom package. While the configuration updates are correct, the yarn.lock file contains extensive unrelated modifications, including downgrading Docusaurus core packages from version 3.8.1 to 3.7.0 and removing the typescript dependency. These unrelated changes should be reverted to prevent potential regressions and ensure the lockfile remains consistent with the project's requirements.

I am having trouble creating individual review comments. Click here to see my feedback.

yarn.lock (1594-1640)

high

The yarn.lock file contains significant unrelated changes, including a downgrade of @docusaurus/core and other Docusaurus packages from version 3.8.1 to 3.7.0. Additionally, several packages like typescript appear to have been removed from the lockfile entirely. These changes are outside the scope of replacing the image zoom plugin and could introduce regressions or break the build. It is recommended to revert these unrelated changes to ensure the lockfile remains consistent with the project's requirements.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Replaces the private GitHub-sourced plugin-image-zoom dependency with the public npm package docusaurus-plugin-image-zoom to unblock fresh installs and CI/Netlify builds.

Changes:

  • Removed the private flexanalytics/plugin-image-zoom dependency and added docusaurus-plugin-image-zoom from npm.
  • Updated docusaurus.config.js to reference the new plugin package name.
  • Regenerated yarn.lock to reflect the dependency swap.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Swaps plugin-image-zoom (GitHub) for docusaurus-plugin-image-zoom (npm).
docusaurus.config.js Updates the configured plugin name to docusaurus-plugin-image-zoom.
yarn.lock Removes the GitHub tarball lock entry and adds npm lock entries for the new plugin and its transitive deps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jayesh9747
Copy link
Copy Markdown
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Netlify Build Fails Due to Private Git Dependency (plugin-image-zoom)

4 participants