fix: replace plugin-image-zoom with docusaurus-plugin-image-zoom#279
fix: replace plugin-image-zoom with docusaurus-plugin-image-zoom#279MeloveGupta wants to merge 1 commit into
Conversation
Signed-off-by: Melove <melovegupta0406@gmail.com>
✅ Deploy Preview for kmesh-net ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request replaces the plugin-image-zoom dependency with the official docusaurus-plugin-image-zoom package. While the configuration updates are correct, the yarn.lock file contains extensive unrelated modifications, including downgrading Docusaurus core packages from version 3.8.1 to 3.7.0 and removing the typescript dependency. These unrelated changes should be reverted to prevent potential regressions and ensure the lockfile remains consistent with the project's requirements.
I am having trouble creating individual review comments. Click here to see my feedback.
yarn.lock (1594-1640)
The yarn.lock file contains significant unrelated changes, including a downgrade of @docusaurus/core and other Docusaurus packages from version 3.8.1 to 3.7.0. Additionally, several packages like typescript appear to have been removed from the lockfile entirely. These changes are outside the scope of replacing the image zoom plugin and could introduce regressions or break the build. It is recommended to revert these unrelated changes to ensure the lockfile remains consistent with the project's requirements.
There was a problem hiding this comment.
Pull request overview
Replaces the private GitHub-sourced plugin-image-zoom dependency with the public npm package docusaurus-plugin-image-zoom to unblock fresh installs and CI/Netlify builds.
Changes:
- Removed the private
flexanalytics/plugin-image-zoomdependency and addeddocusaurus-plugin-image-zoomfrom npm. - Updated
docusaurus.config.jsto reference the new plugin package name. - Regenerated
yarn.lockto reflect the dependency swap.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
package.json |
Swaps plugin-image-zoom (GitHub) for docusaurus-plugin-image-zoom (npm). |
docusaurus.config.js |
Updates the configured plugin name to docusaurus-plugin-image-zoom. |
yarn.lock |
Removes the GitHub tarball lock entry and adds npm lock entries for the new plugin and its transitive deps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/lgtm |
Replaced
plugin-image-zoom(which was pointing to a private GitHub repo viaflexanalytics/plugin-image-zoom) with the public npm packagedocusaurus-plugin-image-zoom.The Netlify build was failing because it couldn't pull a dependency from a private GitHub repo over SSH. Anyone trying to build this project fresh including CI would hit the same wall.
docusaurus-plugin-image-zoomfrom npmdocusaurus.config.jsto matchyarn.lockFixes #248