🛡️ Sentinel: [HIGH] Fix path traversal risk in manual path normalization#233
Open
bashandbone wants to merge 1 commit into
Open
🛡️ Sentinel: [HIGH] Fix path traversal risk in manual path normalization#233bashandbone wants to merge 1 commit into
bashandbone wants to merge 1 commit into
Conversation
Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts manual path normalization in the TypeScript dependency extractor to safely handle parent directory components, preventing path traversal when canonicalization fails, and documents the vulnerability and fix in a Sentinel note. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
ParentDirhandling assumesCurDircan never appear as the last component (unreachable!()); consider documenting or asserting this invariant earlier, or handling it defensively here to avoid panics if upstream behavior changes. - Since this code is re-implementing part of Rust’s path normalization semantics (including
RootDirandPrefix), it may be worth extracting this logic into a small helper with a clear contract so future changes don’t accidentally diverge fromstd::pathbehavior, especially on Windows-style paths.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `ParentDir` handling assumes `CurDir` can never appear as the last component (`unreachable!()`); consider documenting or asserting this invariant earlier, or handling it defensively here to avoid panics if upstream behavior changes.
- Since this code is re-implementing part of Rust’s path normalization semantics (including `RootDir` and `Prefix`), it may be worth extracting this logic into a small helper with a clear contract so future changes don’t accidentally diverge from `std::path` behavior, especially on Windows-style paths.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to harden TypeScript dependency path normalization by changing how manual fallback handling treats .. components when canonicalize() fails, and adds a Sentinel learning note about the vulnerability.
Changes:
- Updates
TypeScriptDependencyExtractor::resolve_module_pathfallback normalization forComponent::ParentDir. - Adds a
.jules/sentinel.mdentry documenting the path traversal lesson.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crates/flow/src/incremental/extractors/typescript.rs |
Adjusts manual path component normalization for TypeScript/JavaScript relative imports. |
.jules/sentinel.md |
Adds documentation about the path traversal issue and prevention guidance. |
Comments suppressed due to low confidence (1)
crates/flow/src/incremental/extractors/typescript.rs:820
- This still normalizes paths all the way to the filesystem root instead of enforcing any project/base-directory boundary. For an absolute source path under a workspace, a specifier with enough
../components can still resolve to a path like/etc/passwdin the fallback path, so the path traversal risk described by the PR is not actually mitigated without a base-path containment check.
components.pop();
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,4 @@ | |||
| ## 2024-05-15 - Path Traversal in Manual Path Component Normalization | |||
Comment on lines
+815
to
+817
| Some(std::path::Component::ParentDir) | None => { | ||
| components.push(component) | ||
| } |
Comment on lines
+813
to
+817
| Some(std::path::Component::RootDir) | ||
| | Some(std::path::Component::Prefix(_)) => {} | ||
| Some(std::path::Component::ParentDir) | None => { | ||
| components.push(component) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 Severity: HIGH
💡 Vulnerability: Path traversal risk during manual path normalization in
TypeScriptDependencyExtractor. Whenstd::fs::canonicalizefails, the manual fallback logic blindly pops components when encountering../. This ignores root directory limits and swallows../inside purely relative paths, allowing potential escapes outside the intended base path if the specifier is crafted.🎯 Impact: An attacker could craft an import specifier with excessive
../components to resolve arbitrary paths relative to the root ifcanonicalizefalls back, potentially exposing or including unintended files.🔧 Fix: Updated the
Component::ParentDirhandling intypescript.rsto accurately mirror Rust's standard path normalization logic. It now ignores../at the root and appropriately pushes../if the stack is empty or the last component is also a../.✅ Verification: Ran
cargo test -p thread-flow --test extractor_typescript_testslocally, which passed all test cases. Cleaned up all scratch files.PR created automatically by Jules for task 15445594305116898096 started by @bashandbone
Summary by Sourcery
Fix TypeScript dependency extraction path normalization to prevent path traversal when canonicalization fails and document the vulnerability and its mitigation.
Bug Fixes:
Documentation: