chore: handle ineligible_guides in guides fetch response#844
chore: handle ineligible_guides in guides fetch response#844thomaswhyyou wants to merge 4 commits intothomas-kno-11142-sdk-guide-toolbar-v2-poc-1from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
3ca6b2e to
bfd9122
Compare
9c6bd46 to
34821df
Compare
34821df to
7963ad8
Compare
|
@cursor review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## thomas-kno-11142-sdk-guide-toolbar-v2-poc-1 #844 +/- ##
==============================================================================
Coverage ? 68.45%
==============================================================================
Files ? 193
Lines ? 8052
Branches ? 1066
==============================================================================
Hits ? 5512
Misses ? 2515
Partials ? 25
|
|
@cursor review |

Description
This PR updates the guide client so it reads
ineligible_guidesfrom the fetch endpoint response and stores into the client state store, to prep ahead of the toolbar changes in downstream PRs.As a reminder, this new field was introduced recently (here) to expose "ineligible markers", a minimal payload that explains which guide was evaluated ineligible for what reason. This information was previously inaccessible to the outside callers, but we want to surface it in the guide toolbar.