Found a problem when not all nodes had the TDMA interface, and solved it.#2
Open
erlender wants to merge 1 commit into
Open
Found a problem when not all nodes had the TDMA interface, and solved it.#2erlender wants to merge 1 commit into
erlender wants to merge 1 commit into
Conversation
…ot have the TDMA interface present and still allow the TDMA cycle to work. Introduced a simple iterator named slotUserId instead. It's the MAC pointer that is needed, not the node id.
Owner
|
Hey. While I get the issue, without revisiting the assumptions in the simulation, I am not sure that this is a general solution, so am reluctant to merge. That is, the |
Contributor
Author
|
Hi,
I understand your reluctance, and it could be a better way to fix this. It just became a showstopper for me, and I spent several hours trying to identify the problem, so I thought I would propose the fix for all. The slotUserId is just a continuous counter to ensure that the time slot allocation table correlates with the created TDMA interfaces.
Erlend
From: Steven Knudsen [mailto:notifications@github.com]
Sent: 22. juni 2018 18:10
To: knud/simple-wireless-tdma
Cc: Larsen, Erlend; Author
Subject: Re: [knud/simple-wireless-tdma] Found a problem when not all nodes had the TDMA interface, and solved it. (#2)
Hey. While I get the issue, without revisiting the assumptions in the simulation, I am not sure that this is a general solution, so am reluctant to merge. That is, the slotUserId is just another kind of constraint that another user of the sim may not like and have to undo. Think I'll leave this unmerged...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFCkfy4c1NDQh3PF1vNAxlevP5FyFH0Sks5t_Ra7gaJpZM4Uzuk1>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed actual node id from slot allocation, to allow some nodes to not have the TDMA interface present and still allow the TDMA cycle to work. Introduced a simple iterator named slotUserId instead. It's the MAC pointer that is needed for the TDMA cycle to be successfully run, not the node id.