Skip to content

Fix: remove duplicate project button and unnecessary spacing#439

Open
Sonalis1299 wants to merge 1 commit into
komalharshita:mainfrom
Sonalis1299:fix/skills-input-render-bug
Open

Fix: remove duplicate project button and unnecessary spacing#439
Sonalis1299 wants to merge 1 commit into
komalharshita:mainfrom
Sonalis1299:fix/skills-input-render-bug

Conversation

@Sonalis1299
Copy link
Copy Markdown

Summary

This PR fixes UI issues in the project generation form section. The duplicate "Generate My Projects" button was removed, and unnecessary spacing caused by an empty error paragraph was fixed by hiding the element when no error message is present. These changes improve the overall user experience and maintain clean form rendering.

Related Issue

Closes #412

Type of Change

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed

File Change made
templates/index.html Removed duplicate Generate My Projects submit button and duplicate IDs
static/css/style.css Added CSS rule to hide empty .form-error-general element and remove unnecessary spacing

How to Test This PR

  1. Clone this branch: git checkout fix/skills-input-render-bug
  2. Install dependencies: pip install -r requirements.txt
  3. Run the app: python app.py
  4. Open http://127.0.0.1:5000 and...
  5. Run the tests: python tests/test_basic.py

Expected test output:

27 passed, 0 failed out of 27 tests

Test Results

30 passed, 0 failed out of 30 tests

Screenshots

Before After
Screenshot 2026-05-22 105229 Screenshot 2026-05-22 105254

Self-Review Checklist

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • I have run python tests/test_basic.py and all 27 tests pass
  • I have run flake8 . locally and there are no errors
  • I have not introduced any print() or console.log() debug statements
  • Every new function I wrote has a docstring
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
  • If I added a project to the dataset, it has all required JSON fields

Notes for Reviewer

This PR focuses only on UI cleanup and duplicate element removal. No application logic was modified.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@Sonalis1299 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

@Sonalis1299
Copy link
Copy Markdown
Author

Hi @komalharshita , I have fixed the issue and all tests are passing successfully. Please review the PR when possible. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug}: Duplicate "Generate my Project" Button

1 participant