Fix: remove duplicate project button and unnecessary spacing#439
Open
Sonalis1299 wants to merge 1 commit into
Open
Fix: remove duplicate project button and unnecessary spacing#439Sonalis1299 wants to merge 1 commit into
Sonalis1299 wants to merge 1 commit into
Conversation
|
@Sonalis1299 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @komalharshita , I have fixed the issue and all tests are passing successfully. Please review the PR when possible. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes UI issues in the project generation form section. The duplicate "Generate My Projects" button was removed, and unnecessary spacing caused by an empty error paragraph was fixed by hiding the element when no error message is present. These changes improve the overall user experience and maintain clean form rendering.
Related Issue
Closes #412
Type of Change
data/projects.jsonWhat Was Changed
templates/index.htmlGenerate My Projectssubmit button and duplicate IDsstatic/css/style.css.form-error-generalelement and remove unnecessary spacingHow to Test This PR
git checkout fix/skills-input-render-bugpip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output:
Test Results
Screenshots
Self-Review Checklist
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
This PR focuses only on UI cleanup and duplicate element removal. No application logic was modified.