Skip to content

Removed duplicated buttons#461

Open
Janvee31 wants to merge 1 commit into
komalharshita:mainfrom
Janvee31:issue-332
Open

Removed duplicated buttons#461
Janvee31 wants to merge 1 commit into
komalharshita:mainfrom
Janvee31:issue-332

Conversation

@Janvee31
Copy link
Copy Markdown
Contributor

@Janvee31 Janvee31 commented May 22, 2026

Summary

This PR fixes a UI duplication issue where the “Generate My Projects” button was rendered twice near the bottom section of the form page. The duplicate button was removed to maintain a cleaner layout and avoid user confusion.

Related Issue

Closes #332

Type of Change

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed [required]

File Change made
templates/index.html Removed the duplicate “Generate My Projects” button from the bottom action section

How to Test This PR

  1. Clone this branch: git checkout your-branch-name
  2. Install dependencies: pip install -r requirements.txt
  3. Run the app: python app.py
  4. Open http://127.0.0.1:5000
  5. Scroll to the “Find Your Next Project” form
  6. Check the space between the “Time Availability” hint text and the action buttons
  7. Confirm the “Generate My Projects” and “Clear Filters” buttons appear closer to the field above, with no excessive blank gap
  8. Resize the page to desktop and mobile widths and verify the spacing still looks balanced

Expected test output:

The form action buttons render once and the vertical spacing above them is tighter and visually consistent.
30 passed, 0 failed out of 30 tests

Test Results [required]

PASS test_projects_json_loads
PASS test_each_project_has_required_fields
PASS test_find_project_by_id_found
PASS test_find_project_by_id_missing
PASS test_parse_skills_basic
PASS test_parse_skills_empty_string
PASS test_parse_skills_single_entry
PASS test_score_single_project_full_match
PASS test_score_single_project_no_match
PASS test_get_recommendations_returns_results
PASS test_get_recommendations_max_three
PASS test_get_recommendations_no_match_returns_empty
PASS test_get_recommendations_result_format
PASS test_validate_all_valid
PASS test_validate_missing_skills
PASS test_validate_missing_level
PASS test_validate_missing_interest
PASS test_validate_missing_time
PASS test_validate_all_missing
PASS test_home_route
PASS test_recommend_api_valid
PASS test_recommend_api_missing_field
PASS test_recommend_api_empty_body
PASS test_project_detail_found
PASS test_project_detail_not_found
PASS test_internal_server_error_page
PASS test_view_code_found
PASS test_download_code_found
PASS test_health_check
PASS test_scoring_weights_has_all_keys

30 passed, 0 failed out of 30 tests


## Screenshots (if UI change)


| Before | After |
|--------|-------|
Before
<img width="1919" height="926" alt="Screenshot 2026-05-19 223630" src="https://github.com/user-attachments/assets/9653f19c-5223-4f12-989d-da807b363555" />

After
<img width="1919" height="925" alt="image" src="https://github.com/user-attachments/assets/b90cf027-c8f3-4bb7-9dc1-8388d3172adc" />
<img width="1218" height="930" alt="image" src="https://github.com/user-attachments/assets/daa3f7f3-3e9b-4cb6-98c0-f8189220248b" />


## Self-Review Checklist [required]

<!-- Complete every item before requesting review. -->
<!-- Do not submit a PR you would not approve yourself. -->

- [x] I have read [CONTRIBUTING.md](../CONTRIBUTING.md) and followed all guidelines
- [ ] My branch name follows the convention: `feat/`, `fix/`, `docs/`, `data/`, `style/`, `test/`
- [x] I have run `python tests/test_basic.py` and all 30 tests pass
- [ ] I have run `flake8 .` locally and there are no errors
- [x] I have not introduced any `print()` or `console.log()` debug statements
- [x] Every new function I wrote has a docstring
- [x] I have not modified files outside the scope of the linked issue
- [x] If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
- [x] If I added a project to the dataset, it has all required JSON fields

## Notes for Reviewer

This PR only changes inline CSS in templates/index.html. No application logic, backend code, or tests were modified.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@Janvee31 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Janvee31
Copy link
Copy Markdown
Contributor Author

Kindly add gssoc-26 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicate “Generate My Projects” Button Appears on Form Page

1 participant