Enhancement: Enable user to download the source code of DevPath as a sample in starter code ready#479
Open
Julliet-Mohanta wants to merge 2 commits into
Open
Enhancement: Enable user to download the source code of DevPath as a sample in starter code ready#479Julliet-Mohanta wants to merge 2 commits into
Julliet-Mohanta wants to merge 2 commits into
Conversation
|
@Julliet-Mohanta is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [required]
Problem:Right now when we click on starter code ready icon on home page, nothing happens.
The changes that I made in the code: As an example to show user what the app actually does, we can link the icon with source code of DevPath, so that when a new user clicks the starter code ready icon, a base source code will already be there.
Basically, that tab is not just for display but it is actually registering the click.
So, I analysed all the files to find the required div in index.html of templated folder. I added an anchor tag of zip file of source code of DevPath along with download attribute and cursor attribute so that when user moves the cursor near svg icon, and click it, automatically, zipped folder will be downloaded.
Related Issue [required]
#340
Closes #340
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
File:/templates/index.html-dded an anchor tag of zip file of source code of DevPath along with download attribute and cursor attribute in div
utils/recommender.pyclear_cache()functiontests/test_basic.pyHow to Test This PR [required]
Screenshots (if UI change)
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer