Skip to content

fix: resolve broken recommendation form submit flow#490

Open
abhinavgomra wants to merge 1 commit into
komalharshita:mainfrom
abhinavgomra:fix/recommend-form-submit-flow
Open

fix: resolve broken recommendation form submit flow#490
abhinavgomra wants to merge 1 commit into
komalharshita:mainfrom
abhinavgomra:fix/recommend-form-submit-flow

Conversation

@abhinavgomra
Copy link
Copy Markdown

Summary [required]

Related Issue [required]

Closes #

Type of Change [required]

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed [required]

File Change made
utils/recommender.py Added clear_cache() function
tests/test_basic.py Added test for cache invalidation

How to Test This PR [required]

  1. Clone this branch: git checkout your-branch-name
  2. Install dependencies: pip install -r requirements.txt
  3. Run the app: python app.py
  4. Open http://127.0.0.1:5000 and...
  5. Run the tests: python tests/test_basic.py

Expected test output:

27 passed, 0 failed out of 27 tests

Test Results [required]

paste output here

Screenshots (if UI change)

Before After
screenshot screenshot

Self-Review Checklist [required]

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • I have run python tests/test_basic.py and all 27 tests pass
  • I have run flake8 . locally and there are no errors
  • I have not introduced any print() or console.log() debug statements
  • Every new function I wrote has a docstring
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
  • If I added a project to the dataset, it has all required JSON fields

Notes for Reviewer

Signed-off-by: abhinavgomra <abhinav.24mip10039@vitbhopal.ac.in>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

Someone is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc-2026 type:bug Something isn't working type:accessibility ui and removed type:bug Something isn't working gssoc-2026 labels May 22, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

Copy link
Copy Markdown
Author

@abhinavgomra abhinavgomra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #

Bug

Recommendation form submit flow was broken due to malformed/duplicated JS logic and duplicate submit element IDs.

Fix

  • Cleaned submit handler and loading/error flow in static/script.js
  • Removed duplicate submit button/duplicate IDs in templates/index.html

Testing

30 passed, 0 failed out of 30 tests

@abhinavgomra
Copy link
Copy Markdown
Author

Hi maintainers, this PR is ready for review. I’ve fixed the broken recommendation submit flow and verified tests locally (30/30 passing). Kindly approve workflows if needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant