fix: resolve broken recommendation form submit flow#490
Open
abhinavgomra wants to merge 1 commit into
Open
Conversation
Signed-off-by: abhinavgomra <abhinav.24mip10039@vitbhopal.ac.in>
|
Someone is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
abhinavgomra
commented
May 22, 2026
Author
abhinavgomra
left a comment
There was a problem hiding this comment.
Closes #
Bug
Recommendation form submit flow was broken due to malformed/duplicated JS logic and duplicate submit element IDs.
Fix
- Cleaned submit handler and loading/error flow in static/script.js
- Removed duplicate submit button/duplicate IDs in templates/index.html
Testing
30 passed, 0 failed out of 30 tests
Author
|
Hi maintainers, this PR is ready for review. I’ve fixed the broken recommendation submit flow and verified tests locally (30/30 passing). Kindly approve workflows if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [required]
Related Issue [required]
Closes #
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
utils/recommender.pyclear_cache()functiontests/test_basic.pyHow to Test This PR [required]
git checkout your-branch-namepip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output:
Test Results [required]
Screenshots (if UI change)
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer