Draft
Conversation
jokestax
requested review from
CristhianF7,
fharper,
futjesus and
jairoFernandez
CristhianF7
requested changes
Aug 12, 2024
Contributor
CristhianF7
left a comment
CristhianF7
left a comment
There was a problem hiding this comment.
I'm blocking until Sept release. We need to adjust the components and discuss the new git auth flow
Contributor
|
His PR on API and the CLI are quite big, I think it may be a bit too much to wait that long before we merge the custom branch. Is it because there are a lot of work to be done on the UI? If it's the case, could we not NOT add anything to the UI for now, and send default repository name, like if someone didn't use the flags with the CLI? That would be one of the time when I'm fine with us having a small disparity with the UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Option for custom repo