Марченко Максим ДЗ 2#55
Open
maks-march wants to merge 4 commits intokontur-courses:masterfrom
Open
Conversation
| .Select(address => CallRequest(address, query)) | ||
| .ToList(); | ||
|
|
||
| var timeoutTask = Task.Delay(timeout).ContinueWith<string>(_ => throw new TimeoutException()); |
There was a problem hiding this comment.
По-хорошему timeoutTask бы создать до всех CallRequest. Иначе выходит, что запросы уже какое-то время как отправлены
| runningTasks.Remove(timeoutTask); | ||
|
|
||
| timeout -= sw.Elapsed; | ||
| if (completedTask == timeoutTask) |
There was a problem hiding this comment.
Если реплики будут тормозить, то соответствующие таски так и останутся в runningTasks, и статистика для них не обновится
| var timeoutTask = Task.Delay(replicaTimeout).ContinueWith<string>(_ => throw new TimeoutException()); | ||
| runningTasks.Add(task, address); | ||
| runningTasks.Add(timeoutTask, "timeout"); | ||
| var sw = Stopwatch.StartNew(); |
There was a problem hiding this comment.
Здесь timeoutTask и Stopwatch тоже лучше перед CallRequest делать
| var replicaTimeout = timeout / (ReplicaAddresses.Length - i); | ||
| var address = orderedReplicas[i]; | ||
| var task = CallRequest(address, query); | ||
| var timeoutTask = Task.Delay(replicaTimeout); |
There was a problem hiding this comment.
timeout и replicaTimeout могут оказаться отрицательными. Task.Delay может или выбросить исключение, или, с маленьким шансом, превратиться в никогда не заканчивающуюся таску
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.