Fix market data review findings and harden test suite#6
Open
Conversation
- Fix drift test: suppress random events, read unrounded prices, use standard-error-based tolerance (was 1000x too tight) - Fix correlation test: suppress random events that drown out the market factor signal (each event jump is ~750x a normal GBM tick) - Add threading.Lock to MassiveProvider._tickers for thread safety parity with SimulatorProvider - Fix PriceCache docstring claiming "re-entrant lock" (uses Lock, not RLock) - Add tests: remove-during-tick safety, price rounding to 4 decimals, empty ticker set skips polling, validate_ticker on 403/429 63/63 tests passing, verified stable across multiple runs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_tickersset now protected bythreading.Lock, matchingSimulatorProvider's patternthreading.Lockvalidate_tickeron 403/429 status codesAll findings from
planning/MARKET_DATA_REVIEW.md. 63/63 tests passing, verified stable across multiple runs.Test plan
uv run pytest tests/ -vpasses 63/63 (up from 57/58 before fixes)🤖 Generated with Claude Code