Bugfix: Force close node server upon finishing response#36
Open
mina-asham wants to merge 1 commit intokriasoft:mainfrom
Open
Bugfix: Force close node server upon finishing response#36mina-asham wants to merge 1 commit intokriasoft:mainfrom
mina-asham wants to merge 1 commit intokriasoft:mainfrom
Conversation
- Relying on clients using the connection close header to close the connection leaves room for client bugs where the server can just hang until the timeout passes, this force clauses the connection completely from the server side but after flushing all the response data - Follow up to: kriasoft#25 - Fixes: kriasoft#35
Contributor
Author
|
@koistya any chance you can review this soon? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
examples/demo-node.jsnpm run build && node examples/demo-node.jshttp://localhost:1234/callback?code=123&status=456