Skip to content

Refactor UI component for catalogs#2733

Open
ppadti wants to merge 3 commits into
kubeflow:mainfrom
ppadti:shared-ui-components
Open

Refactor UI component for catalogs#2733
ppadti wants to merge 3 commits into
kubeflow:mainfrom
ppadti:shared-ui-components

Conversation

@ppadti
Copy link
Copy Markdown
Contributor

@ppadti ppadti commented May 21, 2026

Description

This PR aims to refactor the UI components for catalogs.
This PR needs to go in after #2726

How Has This Been Tested?

Make sure the the page renders and cards renders correctly. All the functionality on landing pages works as expected.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@google-oss-prow google-oss-prow Bot requested review from chambridge and fege May 21, 2026 15:40
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ppadti. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppadti
Copy link
Copy Markdown
Contributor Author

ppadti commented May 21, 2026

/hold until this goes in #2726

ppadti added 3 commits May 26, 2026 18:50
Signed-off-by: ppadti <ppadti@redhat.com>
Signed-off-by: ppadti <ppadti@redhat.com>
Signed-off-by: ppadti <ppadti@redhat.com>
@ppadti ppadti force-pushed the shared-ui-components branch from 89d18d2 to 910217a Compare May 26, 2026 15:00
@ppadti
Copy link
Copy Markdown
Contributor Author

ppadti commented May 26, 2026

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant