fix: remove duplicate logout button from dashboard page#54
fix: remove duplicate logout button from dashboard page#54madhavbansal3006 wants to merge 2 commits into
Conversation
🚀 PR Received SuccessfullyHello @madhavbansal3006, Thank you for taking the initiative to contribute to this project. Please ensure that your PR follows all project guidelines properly before requesting review.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDashboardPage stops destructuring ChangesRemove Duplicate Logout Button
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@madhavbansal3006 provide video for this change |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Hi @kunalverma2512, Since the fix removes a hardcoded button from the code, Before: Two logout buttons were visible — one in navbar After: Only the navbar logout button remains. The duplicate I can provide a demo video if you can share how to |
|
@madhavbansal3006 in telegram group you can discuss with peers |
show a video for your work |
I have attached the 'after' screenshot. Since I am having trouble with the local account creation/login to capture a video, please let me know if there are specific logs or setup steps I should check to get the dashboard fully running for a demo. |
|
@madhavbansal3006 you havent discussed in community , then how will you are going to understand codebase |
|
Hi @kunalverma2512, Thanks for the feedback! I wasn't aware that discussing in the community first was a requirement before submitting a PR. I'll definitely follow that process from now on. Could you guide me to the right place to have these discussions (Discord, GitHub Discussions, etc.)? I want to contribute properly and understand the codebase better with the community's help. Please let me know how you'd like me to proceed with this PR. |
|
join this community group and try to be active from now - click here |
Deniwn22
left a comment
There was a problem hiding this comment.
Good improvement overall. One edge case: empty string vs null aren't treated the same downstream — might need a normalization step.
|
Hi @Deniwn22, thank you for the review! I've resolved the merge conflict in DashboardPage.jsx. Regarding your edge case feedback about empty string vs null — I'll add a normalization step to handle both cases consistently before the data flows downstream. Will push the updated changes shortly. Please have a look once done! |

Fixes #49
Removed the duplicate logout button hardcoded inside
the Dashboard header. The navbar already has a logout
button. Also cleaned up unused imports and functions.
Summary by CodeRabbit