support nodejs 6.x (update nan, use node-gyp)#93
Open
dankang wants to merge 3 commits intokuno:masterfrom
Open
support nodejs 6.x (update nan, use node-gyp)#93dankang wants to merge 3 commits intokuno:masterfrom
dankang wants to merge 3 commits intokuno:masterfrom
Conversation
Contributor
dankang
commented
Jun 22, 2016
- update nan version (2.1.0 => 2.3.5)
- use node-gyp instead of pangyp(deprecated)
- tested on nodejs 4.4.5 & 6.2.2
* update nan version (2.1.0 => 2.3.5) * use node-gyp instead of pangyp(deprecated) * tested on nodejs 4.4.5 & 6.2.2
Contributor
Author
|
@kuno |
Fixed node 6 deprecation warnings
|
@kuno is there any chance to get this merged? There are multiple security issues in the |
|
+1 |
|
node v6 has moved into active LTS mode and a lot of people can't upgrade their projects (myself included) because we have a dependency on this package. This PR really needs to be rolled in at least to make it possible to upgrade. |
|
@kuno - what is the status on this ?. We have an urgent need to have this mergerd due to nsp checks |
|
I needed this so I created |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.