Conversation
- Updated pyproject.toml: Changed Python requirement from ^3.9 to ^3.10 - Updated ruff target-version from py39 to py310 - Added UP007 and UP038 to ruff ignore list to maintain code style - Updated GitHub Actions workflow: Removed Python 3.9 from test matrix - Updated Travis CI config: Removed Python 3.9 from test matrix - Updated README.md: Changed requirement from Python 3.9+ to Python 3.10+ - Updated poetry.lock to reflect new Python version requirement - Removed comment about Python 3.9 from pyproject.toml Co-authored-by: yuji38kwmt <6350027+yuji38kwmt@users.noreply.github.com>
TitleDrop Python 3.9 support, require Python 3.10+ Description
Changes walkthrough 📝
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Pull request overview
This PR drops support for Python 3.9 and sets the minimum required version to Python 3.10+, updating all related configuration files and CI/CD pipelines accordingly.
- Updated Python dependency from
^3.9to^3.10across the project - Removed Python 3.9 from test matrices in GitHub Actions and Travis CI
- Added ruff ignore rules (UP007, UP038) to preserve existing code style patterns
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated Python version requirement to ^3.10, changed ruff target to py310, added UP007/UP038 ignore rules, removed outdated comment about keep-runtime-typing |
| poetry.lock | Regenerated lock file with Poetry 1.8.5 for Python 3.10+, removed Python 3.9-specific dependency markers |
| README.md | Updated requirements documentation from Python 3.9+ to Python 3.10+ |
| .travis.yml | Removed Python 3.9 from test matrix |
| .github/workflows/lint-test.yml | Removed Python 3.9 from test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -127,7 +129,6 @@ convention = "google" | |||
| # 以下のエラーが発生しないようにする。 | |||
There was a problem hiding this comment.
The comment that was removed stated that keep-runtime-typing would no longer be necessary once Python 3.9 support is dropped. However, the setting is still being kept. The comment should be updated rather than removed to explain that the setting is now being maintained for code style consistency rather than Python 3.9 compatibility. Consider updating the comment to reflect the current reasoning, such as: "既存のコードスタイル(Optional[X]など)を維持するため、この設定を使用する" (Using this setting to maintain existing code style such as Optional[X]).
| # 以下のエラーが発生しないようにする。 | |
| # 既存のコードスタイル(Optional[X]など)を維持するため、この設定を使用する |
Updates minimum Python version from 3.9 to 3.10.
Changes
^3.9→^3.10, ruff targetpy39→py310UP007andUP038to ruff ignore list to preserve existingOptional[X]andisinstance((X, Y))patternsOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.