reporter: create status in the base repository of a pull requests#42
Open
Mic92 wants to merge 1 commit intolab132:masterfrom
Open
reporter: create status in the base repository of a pull requests#42Mic92 wants to merge 1 commit intolab132:masterfrom
Mic92 wants to merge 1 commit intolab132:masterfrom
Conversation
Buildbot might not have access to the build status of the fork and for pull request we want the information in the pull request window rather than the commit on the fork.
Author
|
Here is an example: https://git.clan.lol/clan/clan-core/pulls/1458 |
Author
|
Friendly ping |
Contributor
|
Should this case then handled properly? This PR just removes this info in all cases as far as I can tell. |
Author
|
This is handled now properly from my perspective. Before it was trying to access information, which is not available if the pull request comes from a fork. |
Author
|
This has been tested by multiple parties for quite a while now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buildbot might not have access to the build status of the fork and for pull request we want the information in the pull request window rather than the commit on the fork.