feat(BA-5454): add project-scoped model serving search across all layers#10596
Draft
feat(BA-5454): add project-scoped model serving search across all layers#10596
Conversation
fregataa
added a commit
that referenced
this pull request
Mar 26, 2026
fregataa
added a commit
that referenced
this pull request
Mar 26, 2026
3703d12 to
76d836a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a project-scoped model serving endpoint search API path across repository/service/processor layers, with RBAC scope validation for project access.
Changes:
- Introduces
ProjectEndpointSearchScopeand repositorysearch_in_projectfor project-filtered endpoint search. - Adds new
SearchServicesInProjectActionand wires it through service + processor with RBAC scope validation. - Adds unit tests covering project isolation and basic pagination flags.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/manager/repositories/model_serving/test_endpoint_search_in_project.py | Adds repository-level unit tests for project-scoped endpoint search. |
| src/ai/backend/manager/services/model_serving/services/model_serving.py | Adds service method to expose project-scoped search via the repository. |
| src/ai/backend/manager/services/model_serving/processors/model_serving.py | Registers new processor action and applies RBAC scope validator. |
| src/ai/backend/manager/services/model_serving/actions/search_in_project.py | Defines new action + result types for project-scoped search. |
| src/ai/backend/manager/repositories/model_serving/types.py | Adds ProjectEndpointSearchScope with SQL condition + existence check. |
| src/ai/backend/manager/repositories/model_serving/repository.py | Implements repository search_in_project returning ServiceSearchResult. |
| changes/10596.feature.md | Adds changelog entry for the new project-scoped list/search. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/unit/manager/repositories/model_serving/test_endpoint_search_in_project.py
Show resolved
Hide resolved
tests/unit/manager/repositories/model_serving/test_endpoint_search_in_project.py
Show resolved
Hide resolved
tests/unit/manager/repositories/model_serving/test_endpoint_search_in_project.py
Show resolved
Hide resolved
tests/unit/manager/repositories/model_serving/test_endpoint_search_in_project.py
Show resolved
Hide resolved
tests/unit/manager/repositories/model_serving/test_endpoint_search_in_project.py
Show resolved
Hide resolved
tests/unit/manager/repositories/model_serving/test_endpoint_search_in_project.py
Show resolved
Hide resolved
tests/unit/manager/repositories/model_serving/test_endpoint_search_in_project.py
Show resolved
Hide resolved
fregataa
added a commit
that referenced
this pull request
Mar 27, 2026
76d836a to
33a0a21
Compare
Implement search_in_project for model serving endpoints (service list) scoped to a project, for use in the project admin page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace raw project_id field with ProjectEndpointSearchScope object to align with BA-5458 pattern. Service passes action.scope directly to repository instead of creating SearchScope internally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a307b34 to
cde1e87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectEndpointSearchScopeto filter model serving endpoints by projectsearch_in_projectacross repository, service, and processor layers for project-scoped endpoint listingsearch_services_in_projectprocessor with RBAC scope validatorTest plan
Resolves BA-5454