Skip to content

feat(BA-5454): add project-scoped model serving search across all layers#10596

Draft
fregataa wants to merge 3 commits intomainfrom
feat/BA-5454-service-list-project-admin
Draft

feat(BA-5454): add project-scoped model serving search across all layers#10596
fregataa wants to merge 3 commits intomainfrom
feat/BA-5454-service-list-project-admin

Conversation

@fregataa
Copy link
Member

Summary

  • Add ProjectEndpointSearchScope to filter model serving endpoints by project
  • Implement search_in_project across repository, service, and processor layers for project-scoped endpoint listing
  • Register search_services_in_project processor with RBAC scope validator

Test plan

  • Unit tests with real DB: scope filtering, project isolation, pagination fields
  • CI lint/type/test checks

Resolves BA-5454

Copilot AI review requested due to automatic review settings March 26, 2026 15:34
@github-actions github-actions bot added size:XL 500~ LoC comp:manager Related to Manager component labels Mar 26, 2026
fregataa added a commit that referenced this pull request Mar 26, 2026
fregataa added a commit that referenced this pull request Mar 26, 2026
@fregataa fregataa force-pushed the feat/BA-5454-service-list-project-admin branch from 3703d12 to 76d836a Compare March 26, 2026 15:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a project-scoped model serving endpoint search API path across repository/service/processor layers, with RBAC scope validation for project access.

Changes:

  • Introduces ProjectEndpointSearchScope and repository search_in_project for project-filtered endpoint search.
  • Adds new SearchServicesInProjectAction and wires it through service + processor with RBAC scope validation.
  • Adds unit tests covering project isolation and basic pagination flags.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
tests/unit/manager/repositories/model_serving/test_endpoint_search_in_project.py Adds repository-level unit tests for project-scoped endpoint search.
src/ai/backend/manager/services/model_serving/services/model_serving.py Adds service method to expose project-scoped search via the repository.
src/ai/backend/manager/services/model_serving/processors/model_serving.py Registers new processor action and applies RBAC scope validator.
src/ai/backend/manager/services/model_serving/actions/search_in_project.py Defines new action + result types for project-scoped search.
src/ai/backend/manager/repositories/model_serving/types.py Adds ProjectEndpointSearchScope with SQL condition + existence check.
src/ai/backend/manager/repositories/model_serving/repository.py Implements repository search_in_project returning ServiceSearchResult.
changes/10596.feature.md Adds changelog entry for the new project-scoped list/search.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fregataa fregataa marked this pull request as draft March 26, 2026 15:52
fregataa added a commit that referenced this pull request Mar 27, 2026
@fregataa fregataa force-pushed the feat/BA-5454-service-list-project-admin branch from 76d836a to 33a0a21 Compare March 27, 2026 01:50
fregataa and others added 3 commits March 27, 2026 13:30
Implement search_in_project for model serving endpoints (service list)
scoped to a project, for use in the project admin page.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace raw project_id field with ProjectEndpointSearchScope object
to align with BA-5458 pattern. Service passes action.scope directly
to repository instead of creating SearchScope internally.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@fregataa fregataa force-pushed the feat/BA-5454-service-list-project-admin branch from a307b34 to cde1e87 Compare March 27, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:manager Related to Manager component size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants