feat(BA-5427): define VFolder filter and order-by GQL types#10604
Open
seedspirit wants to merge 4 commits intomainfrom
Open
feat(BA-5427): define VFolder filter and order-by GQL types#10604seedspirit wants to merge 4 commits intomainfrom
seedspirit wants to merge 4 commits intomainfrom
Conversation
github-actions
bot
added
size:L
seedspirit
added a commit
that referenced
this pull request
Mar 26, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds DTO and GraphQL input types to support filtering and ordering of VFolder v2 queries (including AND/OR/NOT combinators).
Changes:
- Introduce
VFolderFilter/VFolderOrderrequest DTOs and enum filter DTOs (VFolderStatusFilter,VFolderUsageModeFilter) - Add Strawberry GraphQL filter/order-by inputs for VFolder v2 (
VFolderV2FilterGQL,VFolderV2OrderByGQL, related enums/enum-filters) - Re-export new types from package-level
__init__.pymodules and add a changelog entry
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ai/backend/manager/api/gql/vfolder_v2/types/filters.py | Adds VFolder v2 GraphQL filter inputs, enum filters, and order-by types. |
| src/ai/backend/manager/api/gql/vfolder_v2/types/init.py | Re-exports newly added GraphQL types from the types package. |
| src/ai/backend/manager/api/gql/vfolder_v2/init.py | Re-exports GraphQL types from the vfolder_v2 package top-level. |
| src/ai/backend/common/dto/manager/v2/vfolder/types.py | Adds DTO models for status/usage-mode enum filtering. |
| src/ai/backend/common/dto/manager/v2/vfolder/request.py | Adds DTO models for VFolder filtering and ordering (AND/OR/NOT support). |
| src/ai/backend/common/dto/manager/v2/vfolder/init.py | Re-exports new common DTOs from the vfolder package top-level. |
| changes/10604.feature.md | Documents the new VFolder v2 filter/order-by GraphQL types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jopemachine
reviewed
Mar 27, 2026
Member
|
How is the change to ScopeChainPermissionCheckInput related to adding VFolder filter and order? It would be better to handle it in a separate PR from the type addition. |
jopemachine
reviewed
Mar 27, 2026
- Add VFolderFilter and VFolderOrder DTO classes to common/dto/v2/vfolder/request.py - Add VFolderV2FilterGQL with StringFilter, DateTimeFilter, enum filters, AND/OR/NOT - Add VFolderOperationStatusEnumGQL (9 statuses) and VFolderUsageModeEnumGQL (3 modes) - Add VFolderV2OrderFieldGQL enum and VFolderV2OrderByGQL input - Add gql_field with description to all not_in filter fields - Default order direction: DESC (aligned across DTO and GQL layers) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…olderV2Order Append V2 suffix to follow the v2 DTO naming convention, as pointed out in code review. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jopemachine
reviewed
Mar 27, 2026
jopemachine
reviewed
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VFolderFilterandVFolderOrderDTO classes tocommon/dto/manager/v2/vfolder/request.pywith enum filter types for status and usage modegql/vfolder_v2/types/filters.pywithVFolderV2FilterGQL(name, host, status, usage_mode, created_at + AND/OR/NOT operators),VFolderV2OrderFieldGQLenum, andVFolderV2OrderByGQLinput__init__.pyre-exports for both common DTO and manager GQL packagesTest plan
pants fmtpassespants fixpassespants lint --changed-since=origin/mainpassespants checkpasses in CIResolves BA-5427