Respect WindowBuilder vsync in render surface configuration#175
Merged
Respect WindowBuilder vsync in render surface configuration#175
Conversation
…that vsync/no vsync requests are more likely to be satisfied
✅ Coverage Report📊 View Full HTML Report (download artifact) Overall Coverage
Changed Files in This PR
PR Files Coverage: 12.82% (132/1029 lines) Generated by cargo-llvm-cov · Latest main coverage Last updated: 2026-02-07 22:01:48 UTC · Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes vsync configuration being effectively ignored in some cases by ensuring
the requested present mode is respected end-to-end and that “vsync off”
fallbacks prefer true non-vsync modes when available.
Related Issues
WindowBuilder::with_vsyncis a no-op; present mode hardcoded to Fifo #101Changes
RenderContext(when no explicit present mode is set).AutoNoVsyncoverMailboxwhen the caller requests non-vsync presentation but the adapter does not supportImmediate.WindowBuilder::with_vsyncdocs (best-effort based on platform capabilities).Type of Change
Affected Crates
lambda-rslambda-rs-platformlambda-rs-argslambda-rs-loggingChecklist
cargo +nightly fmt --all)cargo clippy --workspace --all-targets -- -D warnings)cargo test --workspace)Testing
Commands run:
Manual verification steps (if applicable):
WindowBuilder::with_vsync(false)and confirm frame pacing is no longer refresh-capped on platforms that support non-vsync modes.Screenshots/Recordings
N/A
Platform Testing
Additional Notes