Skip to content

feat: auto-discover talk backend#106

Draft
lan17 wants to merge 1 commit into
mainfrom
codex/auto-talk-backend-discovery
Draft

feat: auto-discover talk backend#106
lan17 wants to merge 1 commit into
mainfrom
codex/auto-talk-backend-discovery

Conversation

@lan17
Copy link
Copy Markdown
Owner

@lan17 lan17 commented May 16, 2026

Summary

  • add non-secret RTSP camera identity hints so ONVIF-discovered cameras can preserve manufacturer/model metadata for talk backend selection
  • keep ONVIF first in auto mode, then select Tapo from persisted identity or a passive local digest endpoint hint after ONVIF is unsupported
  • let manual RTSP cameras try passive Tapo discovery and fall back to username admin plus the RTSP password for Tapo credentials
  • update ONVIF camera creation payloads, tests, README, and push-to-talk docs

Validation

  • make lint
  • make typecheck
  • uv run pytest tests/homesec/talk/tapo/test_detector.py tests/homesec/talk/tapo/test_client.py tests/homesec/talk/tapo/test_backend.py tests/homesec/talk/tapo/test_tapo_selector.py tests/homesec/rtsp/test_runtime.py -q
  • cd ui && pnpm test -- OnvifDiscoveryWizard.test.tsx --run
  • make ui-check
  • TEST_DB_DSN=postgresql://homesec:homesec@localhost:15433/homesec make check

Notes

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

❌ Patch coverage is 91.93548% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.19%. Comparing base (0d677d9) to head (7f6bc22).

Files with missing lines Patch % Lines
src/homesec/sources/rtsp/core.py 91.30% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   87.16%   87.19%   +0.02%     
==========================================
  Files         151      151              
  Lines       16422    16537     +115     
==========================================
+ Hits        14314    14419     +105     
- Misses       2108     2118      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant