fix: do not configure 3rd party httpx library's logging#1532
Open
akx wants to merge 1 commit intolangfuse:mainfrom
Open
fix: do not configure 3rd party httpx library's logging#1532akx wants to merge 1 commit intolangfuse:mainfrom
akx wants to merge 1 commit intolangfuse:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing
langfuseshould not change the logging settings for a third-party (httpx) library.Important
Removes
httpxlogger configuration fromlogger.pyto prevent altering third-party library logging settings.httpxlogger inlogger.pyto prevent altering third-party library logging settings.langfuselogger is configured inlogger.pynow, set toWARNINGlevel.This description was created by
for a3e4904. You can customize this summary. It will automatically update as commits are pushed.
Disclaimer: Experimental PR review
Greptile Summary
Removes
httpxlogger configuration fromlangfuse/logger.pyto follow Python best practices. Libraries should not configure logging for third-party dependencies, as this can interfere with application-level logging configurations.Key changes:
httpx_loggerconfiguration (level setting and console handler)langfuselogger is configuredhttpx_loggerwas never exported or referenced elsewhere in the codebaseConfidence Score: 5/5
httpx_loggerwas never exported or used elsewhere in the codebase, and existing tests only referencelangfuse_logger. This is a pure cleanup that follows Python logging best practices.Important Files Changed
httpxlogger configuration to prevent altering third-party library logging settingsLast reviewed commit: a3e4904
(2/5) Greptile learns from your feedback when you react with thumbs up/down!