Skip to content

fix: do not configure 3rd party httpx library's logging#1532

Open
akx wants to merge 1 commit intolangfuse:mainfrom
akx:no-logging-config
Open

fix: do not configure 3rd party httpx library's logging#1532
akx wants to merge 1 commit intolangfuse:mainfrom
akx:no-logging-config

Conversation

@akx
Copy link
Contributor

@akx akx commented Feb 23, 2026

Importing langfuse should not change the logging settings for a third-party (httpx) library.


Important

Removes httpx logger configuration from logger.py to prevent altering third-party library logging settings.

  • Behavior:
    • Removes configuration of httpx logger in logger.py to prevent altering third-party library logging settings.
  • Logging:
    • Only the langfuse logger is configured in logger.py now, set to WARNING level.

This description was created by Ellipsis for a3e4904. You can customize this summary. It will automatically update as commits are pushed.

Disclaimer: Experimental PR review

Greptile Summary

Removes httpx logger configuration from langfuse/logger.py to follow Python best practices. Libraries should not configure logging for third-party dependencies, as this can interfere with application-level logging configurations.

Key changes:

  • Removed httpx_logger configuration (level setting and console handler)
  • Updated module docstring to reflect that only the langfuse logger is configured
  • No breaking changes - the removed httpx_logger was never exported or referenced elsewhere in the codebase

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change removes problematic code that was configuring a third-party library's logger. The removed httpx_logger was never exported or used elsewhere in the codebase, and existing tests only reference langfuse_logger. This is a pure cleanup that follows Python logging best practices.
  • No files require special attention

Important Files Changed

Filename Overview
langfuse/logger.py Removes httpx logger configuration to prevent altering third-party library logging settings

Last reviewed commit: a3e4904

(2/5) Greptile learns from your feedback when you react with thumbs up/down!

@CLAassistant
Copy link

CLAassistant commented Feb 23, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@hassiebp hassiebp self-assigned this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants