Correct testParser_v1_AllParamsPresent to not depend on HashSet iteration order#2
Open
lawrencewang49 wants to merge 1 commit intomasterfrom
Open
Correct testParser_v1_AllParamsPresent to not depend on HashSet iteration order#2lawrencewang49 wants to merge 1 commit intomasterfrom
lawrencewang49 wants to merge 1 commit intomasterfrom
Conversation
38250cd to
cc1e4af
Compare
…on order Updates based on feedback to convert to HashSet and be compatible with Java 8
0e5aaf8 to
0e36daa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
testParser_v1_AllParamsPresentinbt-teststo use a direct comparison for peer addresses.Previously, the test compared
InetPeerAddressvalues by iterating overpeerAddressesin order. However,MagnetUri.getPeerAddresses()returns aCollectionbacked by aSet, which does not guarantee iteration order. This could cause nondeterministic test failures depending on the JVM or hash distribution.Changes made
expectedPeersas aCollectionand compared it with the resultpeerAddressesto remove reliance on iteration order, but still ensuring returned contents are correct.Rationale