-
Notifications
You must be signed in to change notification settings - Fork 20
Docs restyling #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Docs restyling #348
Conversation
Deploying labs-browserpod-previews with
|
| Latest commit: |
eca6cff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://32424d18.labs-browserpod-previews.pages.dev |
| Branch Preview URL: | https://docs-restyling.labs-browserpod-previews.pages.dev |
codingfrog27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I think this is a substantial improvement for user reading experience, great job 🔥
Testing
- I've browsed all preview sites, comparing them with with their live counterpart.
- Search bar is functional on all sites
- random links clicked and work as expected
Colours look good! I like the added "on this page" text as well.
And argument could be made that CheerpX's highlight colour should be more grey/dim. But I think it's good this way for the sake of contrast.
general notes/issues
I did notice a few things. They are not caused by this PR but seem worth noting in general. I've also added them as subtasks to my "further labs improvement" Asana task
- the TOC only start counting from the first heading and dont include the title. This makes the first paragraph non present or clickable
- When an item is clicked in the TOC it will scroll to the first line below the heading, I think it being on the heading would be slightly better
- in CheerpJ. Selecting Japanese from the drop down menu will link to a non existent page.
Changes
To test: