feat: query complexity model for algorithms theory

[Shreyas4991]

This is a highly squashed version of #275 with a smaller commit an comment history for ease of further reviewing.

Authors: Shreyas Srinivas, Tanner Duve, Eric Wieser.

[chenson2018]

This looks in much better shape now, just some relatively minor things from me:

[Shreyas4991]

This looks in much better shape now, just some relatively minor things from me:

@chenson2018 : I think I have addressed all your review comments so far.

[chenson2018]

I pushed one small golf, and my other comments have been addressed. I left the two comments where I'd tagged @eric-wieser unresolved so they can be double checked. As usual, leaving for @fmontesi for final consideration.

[eric-wieser]

Note that the co-authored-by lines in the first commit are not in a form recognized by git

[Shreyas4991]

Note that the co-authored-by lines in the first commit are not in a form recognized by git

I am not a practical git expert. Could you tell me exactly what to do to fix it? The previous commit where I inserted is not the top commit now so I don't know if the commit --amend thing can change this commit's message

[eric-wieser]

I claim that we should reserve the shorter SortOps name for this type, as the other type is neither particularly applicable to most algorithm nor safe for actually counting insertHead operations. I suggest SortOps and SortOpsInsert

[Shreyas4991]

Okay. I will change it.

[Shreyas4991]

I changed it to SortOpsInsertHead I hope that is a better name

[tannerduve]

Note that the co-authored-by lines in the first commit are not in a form recognized by git

I am not a practical git expert. Could you tell me exactly what to do to fix it? The previous commit where I inserted is not the top commit now so I don't know if the commit --amend thing can change this commit's message

you could git commit amend with Co-authored-by: First Last <username@users.noreply.github.com> at the bottom, one line per coauthor. when you merge, all the commits get squashed so I dont think it matters which commit you amend, but note that this would mean all coauthors get equal contribution credit on github, up to you if that matters

[Shreyas4991]

Co-authored-by: First Last username@users.noreply.github.com

Note that the co-authored-by lines in the first commit are not in a form recognized by git

I am not a practical git expert. Could you tell me exactly what to do to fix it? The previous commit where I inserted is not the top commit now so I don't know if the commit --amend thing can change this commit's message

you could git commit amend with Co-authored-by: First Last <username@users.noreply.github.com> at the bottom, one line per coauthor. when you merge, all the commits get squashed so I dont think it matters which commit you amend, but note that this would mean all coauthors get equal contribution credit on github, up to you if that matters

I am not terribly concerned about this. If it ever becomes relevant (let's say this model becomes a paper), there's a long commit trail across two branches and PRs which contains our commit histories, from which we know who contributed what. At least, all I need to do is not delete my branch for this PR, and likewise for all co-authors.

I have pushed the amended commit. Hope it works now.

[tannerduve]

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors looks like you need to add a space before the list of coauthors, also you mistyped Eric's entry. and maybe better to use my official email associated with GitHub, so Co-authored-by: Tanner Duve <tannerduve@gmail.com> not sure if you need to do the same with Eric

[Shreyas4991]

If the commit co author thing doesn't work now, then I am at my wit's end.