(#42) migrate acts-as-taggable-on to the demo_plugin#45
Merged
paranoicsan merged 2 commits intomasterfrom Apr 10, 2026
Merged
Conversation
paranoicsan
reviewed
Apr 8, 2026
Collaborator
paranoicsan
left a comment
paranoicsan
left a comment
There was a problem hiding this comment.
Good job, thank you. I think we can merge it after some minor updates.
alexsdev91
force-pushed
the
42-refactor-tag-model
branch
from
5fc7fa5 to
3c67ce5
Compare
alexsdev91
force-pushed
the
42-refactor-tag-model
branch
from
3c67ce5 to
d36de39
Compare
- Add drop_table for old tags/taggings before creating new ones - Rename migration files and classes to match table names - Restore acts_as_taggable_on :tags on Resource via plugin setup - Remove redundant require "acts-as-taggable-on" from models - Restore where_context scope on PluginDemo::Tag - Add resource tagging integration spec - Document shared gem tables and inter-plugin dependencies - Add ownership comments to models, migrations, and Gemfile Signed-off-by: Alexander Kuznetsov <paranoic.san@gmail.com>
paranoicsan
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#42