feat: Generalise directions for the submarine#2
Open
maazadeeb wants to merge 2 commits intolearnwithjason:mainfrom
Open
feat: Generalise directions for the submarine#2maazadeeb wants to merge 2 commits intolearnwithjason:mainfrom
maazadeeb wants to merge 2 commits intolearnwithjason:mainfrom
Conversation
Author
|
Hey @jlengstorf, I forgot about this PR 😄 I just noticed the dumpster-fire pet on the stream. Do you think I should have the check whether it's a submarine or not, for the rotation towards the top/bottom? Else, the dumpster-fire will start rotating as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1. Since I couldn't get it running on my laptop, I've used this codesandbox to test this.
Also, I couldn't find the required prettier config, so I guessed it based on your current code. You might want to check the formatting locally once.