Bugfix: avoid OOM kill while handling arrays that are spanning multiple streams#58
Open
roeey777 wants to merge 1 commit intoledongthuc:masterfrom
Open
Conversation
starting in a stream and continue into the next stream.
in such case the readArray() method got stuck in an infinite loop
and constantly appended io.EOF to an array - which consumes all
the available memory until an OOM kill by the OS.
the bug was addressed in 2 manners, one it to check for errors
in the readArray() method. the other was to concatenate the
streams so the Interpret function could handle (rather than just
ignore) those kind of arrays.
Signed-off-by: Eyal Royee <eyalroyee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously there was a bug which occurred when an array was starting in a stream and continue into the next stream.
in such case the readArray() method got stuck in an infinite loop and constantly appended io.EOF to an array - which consumes all the available memory until an OOM kill by the OS.
the bug was addressed in 2 manners, one it to check for errors in the readArray() method.
the other was to concatenate the streams so the Interpret function could handle (rather than just ignore) those kind of arrays.