Conversation
| } | ||
|
|
||
| const { props, refsSet, schemaSet } = await server.addProperties({ objectsToAdd, referencesToAdd }); | ||
| // Parse property arguments from CLI or prompt interactively |
There was a problem hiding this comment.
The following code, which generates the props, is redundant. Please move it to a method and use the method here instead.
| } | ||
|
|
||
| const { objectsToAdd, props, referencesToAdd, refsSet, schemaSet } = await server.addProperties(); | ||
| // Parse property arguments from CLI or prompt interactively |
There was a problem hiding this comment.
The following code, which generates the props, is redundant. Please move it to a method and use the method here instead.
| } | ||
|
|
||
| const { props, refsSet, schemaSet } = await server.addProperties({ objectsToAdd, referencesToAdd }); | ||
| // Parse property arguments from CLI or prompt interactively |
There was a problem hiding this comment.
The following code, which generates the props, is redundant. Please move it to a method and use the method here instead.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the LT CLI tool by adding comprehensive documentation and non-interactive mode support for key commands. The changes enable users to run commands with CLI arguments instead of relying solely on interactive prompts, making the tool more suitable for automation and scripting scenarios.
Key changes:
- Added extensive documentation files for Claude Code integration (SKILL.md, examples.md, reference.md)
- Implemented non-interactive mode for
addProp,init,module, andobjectcommands - Created a new
parsePropertiesextension to handle property parsing from CLI arguments - Added a
claude install-skillcommand to install documentation for Claude Code
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/templates/claude-skills/lt-cli/reference.md | New comprehensive reference documentation with command patterns, examples, and troubleshooting |
| src/templates/claude-skills/lt-cli/examples.md | New real-world examples for various use cases (blog, e-commerce, project management, etc.) |
| src/templates/claude-skills/lt-cli/SKILL.md | New skill definition for Claude Code integration with command syntax and best practices |
| src/interfaces/extended-gluegun-toolbox.ts | Added parseProperties method to toolbox interface |
| src/extensions/parse-properties.ts | New extension implementing property parsing from CLI arguments |
| src/commands/server/object.ts | Enhanced with non-interactive mode support using CLI arguments |
| src/commands/server/module.ts | Enhanced with non-interactive mode support using CLI arguments |
| src/commands/server/add-property.ts | Enhanced with non-interactive mode support and fixed empty property list handling |
| src/commands/fullstack/init.ts | Enhanced with non-interactive mode support using CLI arguments |
| src/commands/claude/install-skill.ts | New command to install skill files to ~/.claude/skills/ |
| src/commands/claude/claude.ts | New command group for Claude-related commands |
| LT-CLI-Reference.md | New root-level reference documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } = toolbox; | ||
|
|
||
|
|
||
| // const notInteractivce = toolbox.parameters.options.ni; |
There was a problem hiding this comment.
Commented-out code should be removed. The variable notInteractivce (with typo) is defined but never used.
| // const notInteractivce = toolbox.parameters.options.ni; |
| const { objectsToAdd: newObjects, props, referencesToAdd: newReferences, refsSet, schemaSet } | ||
| = await toolbox.parseProperties({ objectsToAdd, referencesToAdd }); | ||
|
|
||
| // Update lists |
There was a problem hiding this comment.
[nitpick] This comment adds no value as it simply describes what the following code does. Consider removing it or making it more descriptive if the update logic is complex.
| // Update lists |
…, and object with non-interactive usage details
…d-property and module files
…, and object with non-interactive usage details