neoeden: propagate flags to Go tests#1100
Open
uncleDecart wants to merge 2 commits intolf-edge:masterfrom
Open
neoeden: propagate flags to Go tests#1100uncleDecart wants to merge 2 commits intolf-edge:masterfrom
uncleDecart wants to merge 2 commits intolf-edge:masterfrom
Conversation
uncleDecart
requested review from
andrewd-zededa,
milan-zededa and
shjala
and removed request for
milan-zededa
uncleDecart
force-pushed
the
fix-neoeden
branch
from
ea98b81 to
5a35cea
Compare
Member
Author
|
debugging neoeden tests rn.. |
Contributor
|
btw. here it should be |
Member
Author
great catch, thx |
Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart
force-pushed
the
fix-neoeden
branch
2 times, most recently
from
4c37081 to
d299af6
Compare
Contributor
|
@uncleDecart Do you want to rename "kubevirt" tests to "k"? :D |
uncleDecart
force-pushed
the
fix-neoeden
branch
3 times, most recently
from
b683f6e to
942dcc9
Compare
Since neoeden is an all-in-one solution written in Go, we now handle test setup directly within neoeden instead of relying on the setup-environment action. Previously, that action generated configuration via `eden config`, set environment parameters (e.g. TPM vs. no TPM, ZFS vs. ext4), and prepared the test environment. With this change, neoeden performs setup in-house by passing flags directly to `go test`. This commit introduces `framework.go` (working title), which encapsulates setup logic and provides decorators to configure tests based on their required flags and parameters. Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart
force-pushed
the
fix-neoeden
branch
from
942dcc9 to
0052ff6
Compare
Contributor
andrewd-zededa
left a comment
andrewd-zededa
left a comment
There was a problem hiding this comment.
I took a quick look, I'll try to find more time for a detailed review later.
| run: | | ||
| ./eden config set default --key=eve.disks --value=4 | ||
| ./eden config set default --key=eve.disk --value=4096 | ||
| ./eden setup -v debug --grub-options='set_global dom0_extra_args "$dom0_extra_args eve_install_zfs_with_raid_level "' |
Contributor
There was a problem hiding this comment.
Would it be good to place the default raid level value here for readability?
eve_install_zfs_with_raid_level=none
uncleDecart
added a commit
to uncleDecart/eden
that referenced
this pull request
Oct 10, 2025
Temporarily disable NeoEden-related GitHub Actions workflows to prevent LTS testing from being affected by failing tests that consume excessive time and runner resources. These workflows will be re-enabled once PR lf-edge#1100 (which addresses the underlying issues) is merged. Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
milan-zededa
pushed a commit
that referenced
this pull request
Oct 10, 2025
Temporarily disable NeoEden-related GitHub Actions workflows to prevent LTS testing from being affected by failing tests that consume excessive time and runner resources. These workflows will be re-enabled once PR #1100 (which addresses the underlying issues) is merged. Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since neoeden is an all-in-one solution written in Go, we now handle test setup directly within neoeden instead of relying on the setup-environment action. Previously, that action generated configuration via
eden config, set environment parameters (e.g. TPM vs. no TPM, ZFS vs. ext4), and prepared the test environment.With this change, neoeden performs setup in-house by passing flags directly to
go test. This commit introducesframework.go(working title), which encapsulates setup logic and provides decorators to configure tests based on their required flags and parameters.