Implement RuntimeStatus for runtime AppInstances.#120
Draft
andrewd-zededa wants to merge 1 commit intolf-edge:mainfrom
Draft
Implement RuntimeStatus for runtime AppInstances.#120andrewd-zededa wants to merge 1 commit intolf-edge:mainfrom
andrewd-zededa wants to merge 1 commit intolf-edge:mainfrom
Conversation
A nested app runtime instance may need to report an error condition due to user specified config in cloud init. See README_nestedapp.md section 'Runtime Status' for full documentation. Signed-off-by: Andrew Durbin <andrewd@zededa.com>
Contributor
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
Some yetus issues to fix. Otherwise LGTM
| string id = 1; | ||
|
|
||
| // Errors reported by a runtime when applying config eg. cloud-init | ||
| RuntimeErrorInfo err = 2; |
Contributor
There was a problem hiding this comment.
Should this be repeated field since you are mentioning errors in the plural form?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nested app runtime instance may need to report
an error condition due to user specified config
in cloud init.
See README_nestedapp.md section 'Runtime Status'
for full documentation.