Add CERT_STATUS_RENEWAL_PENDING to distinguish in-progress certificate renewals#140
Merged
rene merged 2 commits intolf-edge:mainfrom Mar 4, 2026
Merged
Conversation
…e renewals Introduce a new CertStatus enum value CERT_STATUS_RENEWAL_PENDING to clearly differentiate between certificates that are pending initial enrollment (CERT_STATUS_PENDING) and certificates that are already present and still valid but undergoing renewal. Signed-off-by: Milan Lenco <milan@zededa.com>
No functional changes; generated code and assets only. Signed-off-by: Milan Lenco <milan@zededa.com>
uncleDecart
approved these changes
Mar 2, 2026
rene
reviewed
Mar 4, 2026
| CERT_STATUS_PENDING = 2; | ||
| // Certificate is present and still valid, but a renewal request | ||
| // is in progress and not yet completed. | ||
| CERT_STATUS_RENEWAL_PENDING = 3; |
Contributor
There was a problem hiding this comment.
These Yetus errors are relevant, you are breaking old clients by shifting the numbers, I think in this case is better to just append the new value (CERT_STATUS_RENEWAL_PENDING), is there any major drawback to do so?
Contributor
Author
There was a problem hiding this comment.
The SCEP-support is still a work-in-progress on both EVE and the controller side. No released (or even upstream-merged) code is yet using this enum (or anything in this proto file). That's why I'm ignoring these Yetus errors (sorry, forgot to mention this in the PR description).
Contributor
There was a problem hiding this comment.
ha.... ok, it makes sense. Thanks for the clarification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new
CertStatusenum valueCERT_STATUS_RENEWAL_PENDINGto clearlydifferentiate between certificates that are pending initial enrollment
(
CERT_STATUS_PENDING) and certificates that are already present and stillvalid but undergoing renewal.