Add HA scheme and Kubernetes services to cluster config#141
Merged
eriknordmark merged 2 commits intolf-edge:mainfrom Mar 12, 2026
Merged
Add HA scheme and Kubernetes services to cluster config#141eriknordmark merged 2 commits intolf-edge:mainfrom
eriknordmark merged 2 commits intolf-edge:mainfrom
Conversation
naiming-zededa
force-pushed
the
en-cluster-config-change
branch
from
fdc414a to
2bf568e
Compare
proto/config/edge_node_cluster.proto
Outdated
| message KubernetesService { | ||
| KubernetesServiceType type = 1; | ||
|
|
||
| oneof service_config { |
Contributor
There was a problem hiding this comment.
The oneof aren't really useful. And since all fields are optional you can just define this is a LoadBalancerService, perhaps with a comment that this is optional.
Contributor
Author
There was a problem hiding this comment.
Sure. updated.
naiming-zededa
force-pushed
the
en-cluster-config-change
branch
from
2bf568e to
313dec1
Compare
Contributor
|
Looks like check no uncomitted files is failing in |
Contributor
|
Also, please squash into two commits (one for the proto files and one for the derived) and zero merge commits. |
naiming-zededa
force-pushed
the
en-cluster-config-change
branch
from
313dec1 to
7654024
Compare
- add kubernetes control plane HA scheme, the default is the etcd/raft k3s embedded scheme - add the kubernetes service block, the first one is load-balancer - clarify the existing ClusterType, to be for Native Orchestration or for EVE API based. remove the current HA scheme define from it Signed-off-by: naiming-zededa <naiming@zededa.com>
…onfig - add generated files Signed-off-by: naiming-zededa <naiming@zededa.com>
naiming-zededa
force-pushed
the
en-cluster-config-change
branch
from
7654024 to
5897d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
k3s embedded scheme
for EVE API based. remove the current HA scheme define from it