Conversation
proto/info/info.proto
Outdated
| // Device supports etcd snapshots (e.g. eve-k flavor) | ||
| bool etcd_snapshot = 3; | ||
| // Device supports volume snapshots; on eve-k flavor this should be set to false | ||
| bool volume_snapshots = 4; |
There was a problem hiding this comment.
I don't see how volume_snapshots can be added this way, because the controller will presumably interpret all old EVE versions (which do not know about this even though some versions support snapshot) as sending false (since that is the default value of a boolean in protobuf).
So if you want this you'd need to have a no_volume_snapshot and backport that to 16.0.0 where eve-k would set it to true to indicate it does not support the volume snapshots. I don't know if that is worth it as opposed to having EVE-k generate a helpful error message.
There was a problem hiding this comment.
Sure I will remove volume_snapshots and amend the commit
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
the etcd_snapshot makes sense.
For eve-k: etcd_snapshot = true For non eve-k: etcd_snapshot = false Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
zedi-pramodh
force-pushed
the
enable-etcd-snapshots
branch
from
090ae83 to
ec9cd92
Compare
|
Amended the commit. |
3 participants
Add Optional capabilities to eve-api
etcd-snapshots : this flag will be set to true in eve-k builds and false in eve-kvm builds
volume-snapshots: for now this flag will be set to false in eve-k builds until this feature is implemented and will be set to true in eve-kvm builds since eve-kvm already supports this feature.