Skip to content

Fix annoying flicker #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordalgo merged 1 commit into from
Dec 3, 2025
Merged

Fix annoying flicker #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {
LogLineState,
HoveredLineHint,
MainContent,
SelectedLineHint,
ToolTip,
Examples,
CSourceRow,
Expand Down Expand Up @@ -229,9 +228,6 @@ function App({ testListHeight }: { testListHeight?: number }) {
const fileInputRef = useRef<HTMLInputElement>(null);

const { verifierLogState, logLineIdxToVisualIdx } = visualLogState;

const { line: selectedLine } = selectedState;
const selectedLineVisualIdx = logLineIdxToVisualIdx.get(selectedLine) || 0;
const hoveredLineVisualIdx =
logLineIdxToVisualIdx.get(hoveredState.line) || 0;

Expand Down Expand Up @@ -555,11 +551,6 @@ function App({ testListHeight }: { testListHeight?: number }) {
addPastedCSourceFile={addPastedCSourceFile}
/>
<div id="hint">
<SelectedLineHint
selectedLine={selectedLine}
visualIdx={selectedLineVisualIdx}
lines={verifierLogState.lines}
/>
<HoveredLineHint
hoveredLine={hoveredState.line}
visibleIdx={hoveredLineVisualIdx}
Expand Down
14 changes: 1 addition & 13 deletions src/__snapshots__/App.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,24 +500,12 @@ exports[`App renders the log visualizer when text is pasted 1`] = `
<div
id="hint"
>
<div
class="hint-line"
id="hint-selected-line"
>
<span>
[selected raw line]
1
:
</span>

314: (73) *(u8 *)(r7 +1303) = r1 ; frame1: R1_w=0 R7=map_value(off=0,ks=4,vs=2808,imm=0)
</div>
<div
class="hint-line"
id="hint-hovered-line"
>
<span>
[hovered raw line]
[raw line]
1
:
</span>
Expand Down
22 changes: 1 addition & 21 deletions src/components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ export function HoveredLineHint({
}
return (
<div id="hint-hovered-line" className="hint-line">
<span>[hovered raw line] {visibleIdx + 1}:</span>&nbsp;
<span>[raw line] {visibleIdx + 1}:</span>&nbsp;
{lines[hoveredLine].raw}
</div>
);
Expand Down Expand Up @@ -807,26 +807,6 @@ const StackSlotSpan = ({
);
};

export function SelectedLineHint({
selectedLine,
visualIdx,
lines,
}: {
selectedLine: number;
visualIdx: number;
lines: ParsedLine[];
}) {
if (lines.length === 0) {
return <></>;
}
return (
<div id="hint-selected-line" className="hint-line">
<span>[selected raw line] {visualIdx + 1}:</span>&nbsp;
{lines[selectedLine].raw}
</div>
);
}

function CSourcePastePopup({
verifierLogState,
fileName,
Expand Down
17 changes: 12 additions & 5 deletions src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,14 @@ h1 {

.main-content {
display: flex;
flex: 1;
min-height: 0; /* Important for flex child to respect parent height */
font-size: 14px;
border: 2px solid var(--mid-gray);
border-radius: 4px;
margin: 10px 16px 8px 16px;
margin: 10px 16px 0px 16px;
height: calc(
100% - 136px
); /* This number is the height of the nav bar and the bottom hint container */
}

#input-text {
Expand Down Expand Up @@ -624,14 +626,19 @@ h1 {
/* Footer */

#hint {
padding: 0px 16px 16px 16px;
padding: 10px 16px;
color: var(--primary-dark);
min-height: 40px;
min-height: 20px;
width: 100%;
font-family: "Roboto", sans-serif;
position: absolute;
background-color: var(--mid-gray-20);
border-top: 2px solid var(--mid-gray);
bottom: 0px;
}

.hint-line {
font-size: 16px;
font-size: 14px;
line-height: 20px;
}

Expand Down